[libcamera-devel,v4,0/2] Initial EXIF metadata support
mbox series

Message ID 20200828065727.9909-1-email@uajain.com
Headers show
Series
  • Initial EXIF metadata support
Related show

Message

Umang Jain Aug. 28, 2020, 6:57 a.m. UTC 
Changes in v4:
 - No major changes expect few alphabetically sort fixes,
   commit amend, fix coding/variable style etc.

Changes in v3:
- setTimestamp() now follows the EXIF standard format
  "YYYY:MM:DD hh:mm:ss"
- Strip re-use of EXIF object for every frame.
  A new EXIF object is created and each tag is set for it,
  for each frame while encoding.
- Exif::generate() returns a int code and Exif::data() will
  now return a const libcamera::Span of { exif_data_, size_ }.
- Null terminate strings in Exif::setString().
- Make setLong, setShort, setString etc. helpers private.

Changes in v2:
- Patch 2/3 and 3/3 in v1 are merged.
- We ignore the Frame Metadata timestamp, instead use the 'time of
  encoding' as the frame timestamp for EXIF data. Since the resolution
  is only 1s, this seems to be fine (consensus over IRC).
- EXIF data placeholder is now wrapper inside CameraStream.
  This prevents setting static metadata repeatedly in v1, like
  Make/Model etc.
- Jpeg Encoder encodes the EXIF generated Span<> directly into the
  image. This avoids JPEG encoder dealing with EXIF specifics inside
  itself. 
- Orientation tag value is rectified and is similar to how it's done
  in Chrome HAL.
- Exif::setWidth() and Exif::setHeight() are merged to achieve common
  Exif::setSize(libcamera::Size) for setting frame sizes.

Kieran Bingham (1):
  libcamera: android: Add EXIF infrastructure

Umang Jain (1):
  android: jpeg: Support an initial set of  EXIF metadata tags

 src/android/camera_device.cpp        |  18 ++-
 src/android/jpeg/encoder.h           |   3 +-
 src/android/jpeg/encoder_libjpeg.cpp |   9 +-
 src/android/jpeg/encoder_libjpeg.h   |   3 +-
 src/android/jpeg/exif.cpp            | 234 +++++++++++++++++++++++++++
 src/android/jpeg/exif.h              |  53 ++++++
 src/android/meson.build              |   2 +
 7 files changed, 318 insertions(+), 4 deletions(-)
 create mode 100644 src/android/jpeg/exif.cpp
 create mode 100644 src/android/jpeg/exif.h