[libcamera-devel,0/3] Raspberry Pi ALSC improvements
mbox series

Message ID 20200730111134.641-1-david.plowman@raspberrypi.com
Headers show
Series
  • Raspberry Pi ALSC improvements
Related show

Message

David Plowman July 30, 2020, 11:11 a.m. UTC 
Hi

While working on something else (namely transforms), I noticed a bug in
our ALSC algorithm, as well as a couple of other perhaps overdue
improvements. As was pointed out, better to get these out of the way
first and come back to transforms later!

There are 3 patches, the first being trivial.

* The second patch resamples the luminance correction table, which
  previously we weren't doing. This could have caused artifacts if any
  camera modes were cropping heavily from the sensor.

* The final patch improves switching between modes that crop very
  differently from one another, effectively causing the algorithm to
  start over and generate new initial tables (though without the
  adaptive algorithm).

Hope that makes sense!

Thanks and best regards
David

David Plowman (3):
  libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be
    atomic
  libcamera: ipa: raspberrypi: ALSC: Resample luminance table
  libcamera: ipa: raspberrypi: ALSC: Improve behaviour when camera mode
    changes

 src/ipa/raspberrypi/controller/rpi/alsc.cpp | 89 ++++++++++++++-------
 src/ipa/raspberrypi/controller/rpi/alsc.hpp |  5 +-
 2 files changed, 64 insertions(+), 30 deletions(-)