[libcamera-devel,v2,0/3] libcamera: formats: Remove ImageFormat
mbox series

Message ID 20200721135541.2931205-1-niklas.soderlund@ragnatech.se
Headers show
Series
  • libcamera: formats: Remove ImageFormat
Related show

Message

Niklas Söderlund July 21, 2020, 1:55 p.m. UTC 
Hello,

This series makes use of utils::map_keys() to replace ImageFormat.

This is quiet a late refresh of this series. It addresses all concerns 
of the RFC while extending the pattern to V4L2VideoDevice as suggested 
by Jacopo in the new 3/3 patch.

Niklas Söderlund (3):
  libcamera: v4l2_subdevice: Replace ImageFormats with a map
  libcamera: formats: Remove ImageFormats
  libcamera: v4l2_videodevice: Add using statement for format map

 include/libcamera/internal/camera_sensor.h    |  6 +-
 include/libcamera/internal/formats.h          | 14 ---
 include/libcamera/internal/v4l2_subdevice.h   |  4 +-
 include/libcamera/internal/v4l2_videodevice.h |  4 +-
 src/libcamera/camera_sensor.cpp               | 13 +--
 src/libcamera/formats.cpp                     | 88 -------------------
 .../pipeline/raspberrypi/raspberrypi.cpp      | 13 ++-
 src/libcamera/pipeline/simple/simple.cpp      |  2 +-
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  3 +-
 src/libcamera/v4l2_subdevice.cpp              | 12 ++-
 src/libcamera/v4l2_videodevice.cpp            |  9 +-
 test/v4l2_subdevice/list_formats.cpp          | 16 ++--
 12 files changed, 47 insertions(+), 137 deletions(-)

Comments

Kieran Bingham July 23, 2020, 2:24 p.m. UTC | #1 
Hi Niklas,

I've skimmed through this too, and I can't see anything on top of what
Jacopo said, so:

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

I look forward to the simplifications getting in!

On 21/07/2020 14:55, Niklas Söderlund wrote:
> Hello,
> 
> This series makes use of utils::map_keys() to replace ImageFormat.
> 
> This is quiet a late refresh of this series. It addresses all concerns 
> of the RFC while extending the pattern to V4L2VideoDevice as suggested 
> by Jacopo in the new 3/3 patch.
> 
> Niklas Söderlund (3):
>   libcamera: v4l2_subdevice: Replace ImageFormats with a map
>   libcamera: formats: Remove ImageFormats
>   libcamera: v4l2_videodevice: Add using statement for format map
> 
>  include/libcamera/internal/camera_sensor.h    |  6 +-
>  include/libcamera/internal/formats.h          | 14 ---
>  include/libcamera/internal/v4l2_subdevice.h   |  4 +-
>  include/libcamera/internal/v4l2_videodevice.h |  4 +-
>  src/libcamera/camera_sensor.cpp               | 13 +--
>  src/libcamera/formats.cpp                     | 88 -------------------
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 13 ++-
>  src/libcamera/pipeline/simple/simple.cpp      |  2 +-
>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  3 +-
>  src/libcamera/v4l2_subdevice.cpp              | 12 ++-
>  src/libcamera/v4l2_videodevice.cpp            |  9 +-
>  test/v4l2_subdevice/list_formats.cpp          | 16 ++--
>  12 files changed, 47 insertions(+), 137 deletions(-)
>