[libcamera-devel,RFC,0/8] RFC MappedBuffers
mbox series

Message ID 20200720224232.153717-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • RFC MappedBuffers
Related show

Message

Kieran Bingham July 20, 2020, 10:42 p.m. UTC 
These are some patches which have begun to form the pre-requisite base
for my JPEG software stream work, and as such - I'm posted as an RFC to
get early review while I try to clean up and fix up the JPEG stream.



Kieran Bingham (8):
  libcamera: buffer: Create a MappedFrameBuffer
  libcamera: buffer: Convert copyFrom to use MappedFrameBuffer
  qcam: Convert to use MappedFrameBuffer
  buffer: Provide a base MappedBuffer class
  android: camera_device: Report an error in notifyError()
  android: camera_device: Only construct required planes
  android: camera_device: Query plane length
  RFC-Only: android: camera_device: Provide a MappedCamera3Buffer

 include/libcamera/buffer.h    |  27 +++++++
 src/android/camera_device.cpp |  69 ++++++++++++++++--
 src/libcamera/buffer.cpp      | 132 ++++++++++++++++++++++++++++------
 src/qcam/main_window.cpp      |  27 +++----
 src/qcam/main_window.h        |   2 +-
 src/qcam/viewfinder.cpp       |   4 +-
 src/qcam/viewfinder.h         |   7 +-
 7 files changed, 213 insertions(+), 55 deletions(-)

Comments

Laurent Pinchart July 24, 2020, 5 p.m. UTC | #1 
Hi Kieran,

Thank you for the patch.

On Mon, Jul 20, 2020 at 11:42:24PM +0100, Kieran Bingham wrote:
> These are some patches which have begun to form the pre-requisite base
> for my JPEG software stream work, and as such - I'm posted as an RFC to
> get early review while I try to clean up and fix up the JPEG stream.
> 
> Kieran Bingham (8):
>   libcamera: buffer: Create a MappedFrameBuffer
>   libcamera: buffer: Convert copyFrom to use MappedFrameBuffer
>   qcam: Convert to use MappedFrameBuffer
>   buffer: Provide a base MappedBuffer class
>   android: camera_device: Report an error in notifyError()
>   android: camera_device: Only construct required planes
>   android: camera_device: Query plane length
>   RFC-Only: android: camera_device: Provide a MappedCamera3Buffer
> 
>  include/libcamera/buffer.h    |  27 +++++++
>  src/android/camera_device.cpp |  69 ++++++++++++++++--
>  src/libcamera/buffer.cpp      | 132 ++++++++++++++++++++++++++++------
>  src/qcam/main_window.cpp      |  27 +++----
>  src/qcam/main_window.h        |   2 +-
>  src/qcam/viewfinder.cpp       |   4 +-
>  src/qcam/viewfinder.h         |   7 +-

In case you're not aware yet, this is missing a unit test.

>  7 files changed, 213 insertions(+), 55 deletions(-)