[libcamera-devel,v4,00/19] ipu3: rework pipe confiuguration

8872 mbox series

Hello,
  addressed Laurent's most trivial comments on 02 and 03 and 13.

Reworked 13 to use the new in-place Size modifiers and expand comments.

The series is mostly reviewed in full by Laurent and Niklas, expect from
13/19 and 17/19 which represent the most juicy parts.

I plan to push the stand-alone patches not related to the ipu3 pipeline handler
to reduce the size of an eventual v5.

Thanks
  j

Jacopo Mondi (19):
  libcamera: ipu3: Rename mbusCodesToInfo
  libcamera: utils: Add alignUp and alignDown functions
  libcamera: geometry: Add isNull() function to Rectangle class
  libcamera: ipu3: Remove streams from generateConfiguration
  libcamera: ipu3: Make sure the config is valid
  libcamera: ipu3: cio2: Report format and sizes
  libcamera: ipu3: Do not overwrite StreamConfiguration
  libcamera: ipu3: Report StreamFormats
  libcamera: ipu3: Remove initialization of Size
  libcamera: ipu3: Validate the stream combination
  libcamera: camera: Zero streams before validate()
  libcamera: ipu3: cio2: Add a const sensor() method
  libcamera: ipu3: Adjust and assign streams in validate()
  libcamera: ipu3: Remove streams from IPU3CameraConfiguration
  libcamera: ipu3: Remove camera_ from IPU3CameraConfiguration
  libcamera: ipu3: imgu: Calculate ImgU pipe configuration
  libcamera: ipu3: Validate the pipe configuration
  libcamera: ipu3: Configure ImgU with the computed parameters
  libcamera: ipu3: imgu: Rename configureInput()

 include/libcamera/geometry.h         |   1 +
 include/libcamera/internal/utils.h   |  10 +
 src/libcamera/camera.cpp             |   4 +-
 src/libcamera/geometry.cpp           |   6 +
 src/libcamera/pipeline/ipu3/cio2.cpp |  54 +++-
 src/libcamera/pipeline/ipu3/cio2.h   |   6 +
 src/libcamera/pipeline/ipu3/imgu.    |   0
 src/libcamera/pipeline/ipu3/imgu.cpp | 378 +++++++++++++++++++++++-
 src/libcamera/pipeline/ipu3/imgu.h   |  22 +-
 src/libcamera/pipeline/ipu3/ipu3.cpp | 423 +++++++++++++--------------
 src/libcamera/utils.cpp              |  16 +
 test/geometry.cpp                    |  14 +
 test/utils.cpp                       |  11 +
 13 files changed, 705 insertions(+), 240 deletions(-)
 create mode 100644 src/libcamera/pipeline/ipu3/imgu.

--
2.27.0