[libcamera-devel,0/5] libcamera: Various improvements to geometry classes
mbox series

Message ID 20200714234009.16596-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: Various improvements to geometry classes
Related show

Message

Laurent Pinchart July 14, 2020, 11:40 p.m. UTC 
Hello,

This patch series brings various improvements (at least according to me
:-)) to the Size and Rectangle classes. Please see individual patches
for details.

Laurent Pinchart (5):
  libcamera: geometry: Don't default-initialize Size unnecessarily
  libcamera: geometry: Define Rectangle after Size
  libcamera: geometry: Give constructors to Rectangle
  libcamera: geometry: Turn Size and Rectangle into classes
  libcamera: geometry: Make Size and Rectangle usable as constexpr

 include/libcamera/geometry.h                  |  65 +++++---
 src/libcamera/camera_sensor.cpp               |   2 +-
 src/libcamera/geometry.cpp                    | 144 ++++++++++--------
 src/libcamera/pipeline/ipu3/cio2.h            |   2 +-
 src/libcamera/pipeline/ipu3/imgu.cpp          |   7 +-
 src/libcamera/pipeline/ipu3/imgu.h            |   2 +-
 .../pipeline/raspberrypi/raspberrypi.cpp      |  11 +-
 src/libcamera/pipeline/simple/converter.h     |   2 +-
 src/libcamera/pipeline/vimc/vimc.cpp          |   7 +-
 9 files changed, 135 insertions(+), 107 deletions(-)

Comments

Kieran Bingham July 15, 2020, 2:41 p.m. UTC | #1 
Hi Laurent,

On 15/07/2020 00:40, Laurent Pinchart wrote:
> Hello,
> 
> This patch series brings various improvements (at least according to me
> :-)) to the Size and Rectangle classes. Please see individual patches
> for details.
> 

Looks good to me. Nothing I could find to address, so for the series:

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Laurent Pinchart (5):
>   libcamera: geometry: Don't default-initialize Size unnecessarily
>   libcamera: geometry: Define Rectangle after Size
>   libcamera: geometry: Give constructors to Rectangle
>   libcamera: geometry: Turn Size and Rectangle into classes
>   libcamera: geometry: Make Size and Rectangle usable as constexpr
> 
>  include/libcamera/geometry.h                  |  65 +++++---
>  src/libcamera/camera_sensor.cpp               |   2 +-
>  src/libcamera/geometry.cpp                    | 144 ++++++++++--------
>  src/libcamera/pipeline/ipu3/cio2.h            |   2 +-
>  src/libcamera/pipeline/ipu3/imgu.cpp          |   7 +-
>  src/libcamera/pipeline/ipu3/imgu.h            |   2 +-
>  .../pipeline/raspberrypi/raspberrypi.cpp      |  11 +-
>  src/libcamera/pipeline/simple/converter.h     |   2 +-
>  src/libcamera/pipeline/vimc/vimc.cpp          |   7 +-
>  9 files changed, 135 insertions(+), 107 deletions(-)
>