[libcamera-devel,0/2] Replace vcsm with dmabuf alloc
mbox series

Message ID 20200714120844.520732-1-naush@raspberrypi.com
Headers show
Series
  • Replace vcsm with dmabuf alloc
Related show

Message

Naushir Patuck July 14, 2020, 12:08 p.m. UTC 
Hi,

This patch replaces the existing vcsm with dmabuf allocations for the lens shading tables.
This change will break existing functionality without the equivalent linux kernel
change (https://github.com/raspberrypi/linux/pull/3715) being present and built..

Laurent, since this is an ABI breakage, once the review is complete, could you
let me know before you are about to merge this change so we can sync push the
kernel change at the same time and inform our users please?

Thanks,
Naush


Naushir Patuck (2):
  include: linux: Add dma-buf.h and dma-heap.h uapi headers
  libcamera: pipeline: ipa: raspberrypi: Use dma heap allocs for LS
    tables

 include/linux/bcm2835-isp.h                   |   4 +-
 include/linux/dma-buf.h                       |  50 ++++++
 include/linux/dma-heap.h                      |  53 +++++++
 include/linux/vc_sm_cma_ioctl.h               | 135 ----------------
 src/ipa/raspberrypi/raspberrypi.cpp           |  27 +++-
 .../pipeline/raspberrypi/dma-heaps.h          | 102 ++++++++++++
 .../pipeline/raspberrypi/raspberrypi.cpp      |  44 ++----
 src/libcamera/pipeline/raspberrypi/vcsm.h     | 149 ------------------
 8 files changed, 241 insertions(+), 323 deletions(-)
 create mode 100644 include/linux/dma-buf.h
 create mode 100644 include/linux/dma-heap.h
 delete mode 100644 include/linux/vc_sm_cma_ioctl.h
 create mode 100644 src/libcamera/pipeline/raspberrypi/dma-heaps.h
 delete mode 100644 src/libcamera/pipeline/raspberrypi/vcsm.h

Comments

Laurent Pinchart July 14, 2020, 6:14 p.m. UTC | #1 
Hi Naush,

On Tue, Jul 14, 2020 at 01:08:42PM +0100, Naushir Patuck wrote:
> Hi,
> 
> This patch replaces the existing vcsm with dmabuf allocations for the lens shading tables.
> This change will break existing functionality without the equivalent linux kernel
> change (https://github.com/raspberrypi/linux/pull/3715) being present and built..
> 
> Laurent, since this is an ABI breakage, once the review is complete, could you
> let me know before you are about to merge this change so we can sync push the
> kernel change at the same time and inform our users please?

Sure, I'll do so.

> Naushir Patuck (2):
>   include: linux: Add dma-buf.h and dma-heap.h uapi headers
>   libcamera: pipeline: ipa: raspberrypi: Use dma heap allocs for LS
>     tables
> 
>  include/linux/bcm2835-isp.h                   |   4 +-
>  include/linux/dma-buf.h                       |  50 ++++++
>  include/linux/dma-heap.h                      |  53 +++++++
>  include/linux/vc_sm_cma_ioctl.h               | 135 ----------------
>  src/ipa/raspberrypi/raspberrypi.cpp           |  27 +++-
>  .../pipeline/raspberrypi/dma-heaps.h          | 102 ++++++++++++
>  .../pipeline/raspberrypi/raspberrypi.cpp      |  44 ++----
>  src/libcamera/pipeline/raspberrypi/vcsm.h     | 149 ------------------
>  8 files changed, 241 insertions(+), 323 deletions(-)
>  create mode 100644 include/linux/dma-buf.h
>  create mode 100644 include/linux/dma-heap.h
>  delete mode 100644 include/linux/vc_sm_cma_ioctl.h
>  create mode 100644 src/libcamera/pipeline/raspberrypi/dma-heaps.h
>  delete mode 100644 src/libcamera/pipeline/raspberrypi/vcsm.h