[libcamera-devel,v2,0/2] Digital zoom implementation
mbox series

Message ID 20200709091555.1617-1-david.plowman@raspberrypi.com
Headers show
Series
  • Digital zoom implementation
Related show

Message

David Plowman July 9, 2020, 9:15 a.m. UTC 
Hi everyone

Here's version 2 of this patch set, which addresses the issues that
Naush raised with regard to the Raspberry Pi implementation (the
second commit).

The basic idea of this digital zoom implementation is still unchanged,
however, and merits some discussion. In particular:

* I've got this rather awkward getSensorCrop() function which gets the
  the dimension of the rectange, in pixels, within which you can zoom.

* Is there any other way to get this rectangle? It's only the pipeline
  handler that actually calculates what it is.

* Or would we be better off with ratios rather than pixels (which
  would obviate the need for the function)? Pixels sound useful,
  though I think folks will actually calculate them using ratios in a
  real application.

Thoughts welcome as always!

Thanks and best regards
David

David Plowman (2):
  libcamera: Implement digital zoom
  libcamera: raspberrypi: Implement digital zoom

 include/libcamera/camera.h                    |  2 +
 include/libcamera/internal/pipeline_handler.h |  4 ++
 include/libcamera/ipa/raspberrypi.h           |  1 +
 src/ipa/raspberrypi/raspberrypi.cpp           | 10 ++++
 src/libcamera/camera.cpp                      | 26 +++++++++
 src/libcamera/control_ids.yaml                | 10 ++++
 .../pipeline/raspberrypi/raspberrypi.cpp      | 56 ++++++++++++++++++-
 7 files changed, 108 insertions(+), 1 deletion(-)