[libcamera-devel,v2,0/3] cam: options: Add support for repeatable options
mbox series

Message ID 20190327002107.24487-1-niklas.soderlund@ragnatech.se
Headers show
Series
  • cam: options: Add support for repeatable options
Related show

Message

Niklas Söderlund March 27, 2019, 12:21 a.m. UTC 
Hi,

This series extends the option parser for the cam tool to support
repeatable options. This will be needed to extend the tool to support
multiple streams.

This was posted earlier as a RFC that included a fourth patch to make
use of the new interface in the cam utility. That patch was incomplete
and did not fully add multiple stream support to the cam tool and is
therefor dropped in this non-RFC series which is intended to be merged

All patches have review tags but as there was some debate in v1 I post 
v2 and let it stew for a day or two before pushing it in case someone 
have additional comment.

Niklas Söderlund (3):
  cam: options: Create separate enum for OptionValue types
  cam: options: Add an array data type to OptionValue
  cam: options: Add support for repeatable options

 src/cam/options.cpp | 59 ++++++++++++++++++++++++++++++++++-----------
 src/cam/options.h   | 23 +++++++++++++++---
 2 files changed, 64 insertions(+), 18 deletions(-)

Comments

Jacopo Mondi March 27, 2019, 8:07 a.m. UTC | #1 
Hi Niklas,

On Wed, Mar 27, 2019 at 01:21:04AM +0100, Niklas Söderlund wrote:
> Hi,
>
> This series extends the option parser for the cam tool to support
> repeatable options. This will be needed to extend the tool to support
> multiple streams.
>
> This was posted earlier as a RFC that included a fourth patch to make
> use of the new interface in the cam utility. That patch was incomplete
> and did not fully add multiple stream support to the cam tool and is
> therefor dropped in this non-RFC series which is intended to be merged
>
> All patches have review tags but as there was some debate in v1 I post
> v2 and let it stew for a day or two before pushing it in case someone
> have additional comment.
>

Don't hold this series for my comments on v1 as it seems they are not
addressable.

Thanks
  j

> Niklas Söderlund (3):
>   cam: options: Create separate enum for OptionValue types
>   cam: options: Add an array data type to OptionValue
>   cam: options: Add support for repeatable options
>
>  src/cam/options.cpp | 59 ++++++++++++++++++++++++++++++++++-----------
>  src/cam/options.h   | 23 +++++++++++++++---
>  2 files changed, 64 insertions(+), 18 deletions(-)
>
> --
> 2.21.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Niklas Söderlund March 27, 2019, 2:08 p.m. UTC | #2 
Hi,

On 2019-03-27 09:07:44 +0100, Jacopo Mondi wrote:
> Hi Niklas,
> 
> On Wed, Mar 27, 2019 at 01:21:04AM +0100, Niklas Söderlund wrote:
> > Hi,
> >
> > This series extends the option parser for the cam tool to support
> > repeatable options. This will be needed to extend the tool to support
> > multiple streams.
> >
> > This was posted earlier as a RFC that included a fourth patch to make
> > use of the new interface in the cam utility. That patch was incomplete
> > and did not fully add multiple stream support to the cam tool and is
> > therefor dropped in this non-RFC series which is intended to be merged
> >
> > All patches have review tags but as there was some debate in v1 I post
> > v2 and let it stew for a day or two before pushing it in case someone
> > have additional comment.
> >
> 
> Don't hold this series for my comments on v1 as it seems they are not
> addressable.

Thanks, I have now pushed this series to master.

> 
> Thanks
>   j
> 
> > Niklas Söderlund (3):
> >   cam: options: Create separate enum for OptionValue types
> >   cam: options: Add an array data type to OptionValue
> >   cam: options: Add support for repeatable options
> >
> >  src/cam/options.cpp | 59 ++++++++++++++++++++++++++++++++++-----------
> >  src/cam/options.h   | 23 +++++++++++++++---
> >  2 files changed, 64 insertions(+), 18 deletions(-)
> >
> > --
> > 2.21.0
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel@lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel