[libcamera-devel,0/3] Fix LOG usage
mbox series

Message ID 20190213122035.25309-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • Fix LOG usage
Related show

Message

Kieran Bingham Feb. 13, 2019, 12:20 p.m. UTC 
The LOG output should always provide a category.

Update various locations where this was not provided.

Kieran Bingham (3):
  libcamera: v4l2_device: Fix LOG usage
  libcamera: v4l2_subdevice: Fix LOG usage
  libcamera: device_enumerator: Fix LOG usage

 src/libcamera/device_enumerator.cpp | 3 ++-
 src/libcamera/v4l2_device.cpp       | 8 ++++----
 src/libcamera/v4l2_subdevice.cpp    | 3 ++-
 3 files changed, 8 insertions(+), 6 deletions(-)

Comments

Laurent Pinchart Feb. 13, 2019, 3:37 p.m. UTC | #1 
Hi Kieran,

Thank you for the patches.

On Wed, Feb 13, 2019 at 12:20:32PM +0000, Kieran Bingham wrote:
> The LOG output should always provide a category.
> 
> Update various locations where this was not provided.
> 
> Kieran Bingham (3):
>   libcamera: v4l2_device: Fix LOG usage
>   libcamera: v4l2_subdevice: Fix LOG usage
>   libcamera: device_enumerator: Fix LOG usage

For the whole series,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  src/libcamera/device_enumerator.cpp | 3 ++-
>  src/libcamera/v4l2_device.cpp       | 8 ++++----
>  src/libcamera/v4l2_subdevice.cpp    | 3 ++-
>  3 files changed, 8 insertions(+), 6 deletions(-)