[libcamera-devel,v3,0/4] libcamera sharpness strength control

4139 mbox series

Hi

Version 3 of the sharpness control patch - same as v2 except:

* Commit messages tidied a little.

* In commit 3 I've made the user_strength_ parameter a regular double
  too, as everything does get serialised within our pipeline handler.

Thanks and best regards
David

David Plowman (4):
  libcamera: Add a sharpness strength control
  libcamera: ipa: raspberrypi: Make sharpening mode_factor an ordinary
    double
  libcamera: ipa: raspberrypi: Add sharpness strength control
  libcamera: ipa: raspberrypi: plumb in the libcamera sharpness control

 include/libcamera/ipa/raspberrypi.h           |  1 +
 .../raspberrypi/controller/rpi/sharpen.cpp    | 29 +++++++++++++++----
 .../raspberrypi/controller/rpi/sharpen.hpp    |  8 +++--
 .../controller/sharpen_algorithm.hpp          | 21 ++++++++++++++
 .../raspberrypi/controller/sharpen_status.h   |  2 ++
 src/ipa/raspberrypi/raspberrypi.cpp           | 12 ++++++++
 src/libcamera/control_ids.yaml                | 12 ++++++++
 7 files changed, 76 insertions(+), 9 deletions(-)
 create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp

Hi David,

On Tue, Jun 23, 2020 at 10:14:00AM +0100, David Plowman wrote:
> Hi
> 
> Version 3 of the sharpness control patch - same as v2 except:
> 
> * Commit messages tidied a little.
> 
> * In commit 3 I've made the user_strength_ parameter a regular double
>   too, as everything does get serialised within our pipeline handler.

Thank you. I've applied the series with one small fix in patch 3/4. It's
going through compilation tests right now, and I'll push to master right
after (or reply to this e-mail if anything goes wrong).

In the future, when you post new versions of patch series, could you try
to apply the tags received in previous versions ? I had replied with a
Reviewed-by for 1/4, 2/4 and 4/4 in v2. This would make it easier to
track what patches have been reviewed already.

> David Plowman (4):
>   libcamera: Add a sharpness strength control
>   libcamera: ipa: raspberrypi: Make sharpening mode_factor an ordinary
>     double
>   libcamera: ipa: raspberrypi: Add sharpness strength control
>   libcamera: ipa: raspberrypi: plumb in the libcamera sharpness control
> 
>  include/libcamera/ipa/raspberrypi.h           |  1 +
>  .../raspberrypi/controller/rpi/sharpen.cpp    | 29 +++++++++++++++----
>  .../raspberrypi/controller/rpi/sharpen.hpp    |  8 +++--
>  .../controller/sharpen_algorithm.hpp          | 21 ++++++++++++++
>  .../raspberrypi/controller/sharpen_status.h   |  2 ++
>  src/ipa/raspberrypi/raspberrypi.cpp           | 12 ++++++++
>  src/libcamera/control_ids.yaml                | 12 ++++++++
>  7 files changed, 76 insertions(+), 9 deletions(-)
>  create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp

Hi Laurent

Thanks for taking care of this.

On Thu, 25 Jun 2020 at 04:28, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi David,
>
> On Tue, Jun 23, 2020 at 10:14:00AM +0100, David Plowman wrote:
> > Hi
> >
> > Version 3 of the sharpness control patch - same as v2 except:
> >
> > * Commit messages tidied a little.
> >
> > * In commit 3 I've made the user_strength_ parameter a regular double
> >   too, as everything does get serialised within our pipeline handler.
>
> Thank you. I've applied the series with one small fix in patch 3/4. It's
> going through compilation tests right now, and I'll push to master right
> after (or reply to this e-mail if anything goes wrong).
>
> In the future, when you post new versions of patch series, could you try
> to apply the tags received in previous versions ? I had replied with a
> Reviewed-by for 1/4, 2/4 and 4/4 in v2. This would make it easier to
> track what patches have been reviewed already.

Will do. I'll also double-check if my checkstyle.py is working, I thought
I'd done that but it's entirely possible I got it wrong!

Best regards
David

>
> > David Plowman (4):
> >   libcamera: Add a sharpness strength control
> >   libcamera: ipa: raspberrypi: Make sharpening mode_factor an ordinary
> >     double
> >   libcamera: ipa: raspberrypi: Add sharpness strength control
> >   libcamera: ipa: raspberrypi: plumb in the libcamera sharpness control
> >
> >  include/libcamera/ipa/raspberrypi.h           |  1 +
> >  .../raspberrypi/controller/rpi/sharpen.cpp    | 29 +++++++++++++++----
> >  .../raspberrypi/controller/rpi/sharpen.hpp    |  8 +++--
> >  .../controller/sharpen_algorithm.hpp          | 21 ++++++++++++++
> >  .../raspberrypi/controller/sharpen_status.h   |  2 ++
> >  src/ipa/raspberrypi/raspberrypi.cpp           | 12 ++++++++
> >  src/libcamera/control_ids.yaml                | 12 ++++++++
> >  7 files changed, 76 insertions(+), 9 deletions(-)
> >  create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp
>
> --
> Regards,
>
> Laurent Pinchart