[libcamera-devel,v2,0/2] Raspberry pi IPAs: update sensor exposure/gain when camera mode changes
mbox series

Message ID 20200618111236.26897-1-david.plowman@raspberrypi.com
Headers show
Series
  • Raspberry pi IPAs: update sensor exposure/gain when camera mode changes
Related show

Message

David Plowman June 18, 2020, 11:12 a.m. UTC 
Hi

Here's version 2 of this patch hopefully taking the review comments
into account. When a new sensor mode is selected, and the pipeline
re-configured, the exposure/gain must be recalculated because:

1. an application might select a new exposure profile from the camera
tuning which divides up the exposure/gain differently, and

2. the line timings may change, and the sensor driver stores exposure
as a number of lines, meaning the time could change "under our feet"
if we didn't recalculate the lines correctly.

Best regards
David

David Plowman (2):
  libcamera: raspberrypi: allow SwitchMode method to return camera
    settings
  libcamera: raspberrypi: recalculate camera exposure/gain when camera
    mode changes

 src/ipa/raspberrypi/controller/algorithm.cpp  |  3 +-
 src/ipa/raspberrypi/controller/algorithm.hpp  |  2 +-
 src/ipa/raspberrypi/controller/controller.cpp |  4 +--
 src/ipa/raspberrypi/controller/controller.hpp |  2 +-
 src/ipa/raspberrypi/controller/rpi/agc.cpp    | 12 ++++++++
 src/ipa/raspberrypi/controller/rpi/agc.hpp    |  1 +
 src/ipa/raspberrypi/controller/rpi/alsc.cpp   |  4 ++-
 src/ipa/raspberrypi/controller/rpi/alsc.hpp   |  2 +-
 src/ipa/raspberrypi/controller/rpi/noise.cpp  |  4 ++-
 src/ipa/raspberrypi/controller/rpi/noise.hpp  |  2 +-
 .../raspberrypi/controller/rpi/sharpen.cpp    |  4 ++-
 .../raspberrypi/controller/rpi/sharpen.hpp    |  2 +-
 src/ipa/raspberrypi/raspberrypi.cpp           | 28 ++++++++++---------
 13 files changed, 46 insertions(+), 24 deletions(-)