Message ID | 20200608133639.533230-1-naush@raspberrypi.com |
---|---|
Headers | show |
Series |
|
Related | show |
Hi all, Gentle nudge to have some feedback on this please. Thanks, Naush On Mon, 8 Jun 2020 at 14:36, Naushir Patuck <naush@raspberrypi.com> wrote: > > Hi all, > > The last patch on this topic generated some useful comments. I've updated > the patch with the recommendations so we can continue discussion on this feature. > > Regards, > Naush > > Naushir Patuck (3): > libcamera: controls: Add frame duration control > libcamera: raspberrypi: Add control of sensor vblanking > ipa: raspberrypi: config: Update shutter speeds for imx219/477 and > ov5647 > > include/libcamera/ipa/raspberrypi.h | 1 + > src/ipa/raspberrypi/cam_helper.cpp | 38 ++++++++++++++- > src/ipa/raspberrypi/cam_helper.hpp | 15 +++++- > src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- > src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 ++++- > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 ++++- > src/ipa/raspberrypi/data/imx219.json | 15 +++++- > src/ipa/raspberrypi/data/imx477.json | 15 +++++- > src/ipa/raspberrypi/data/ov5647.json | 15 +++++- > src/ipa/raspberrypi/raspberrypi.cpp | 48 ++++++++++++++++--- > src/libcamera/control_ids.yaml | 18 +++++++ > .../pipeline/raspberrypi/raspberrypi.cpp | 2 + > 12 files changed, 182 insertions(+), 20 deletions(-) > > -- > 2.25.1 >
Hi Naush, On Wed, Jun 24, 2020 at 09:19:15AM +0100, Naushir Patuck wrote: > Hi all, > > Gentle nudge to have some feedback on this please. I'm sorry for the delay. I'll handle this one today. > On Mon, 8 Jun 2020 at 14:36, Naushir Patuck <naush@raspberrypi.com> wrote: > > > > Hi all, > > > > The last patch on this topic generated some useful comments. I've updated > > the patch with the recommendations so we can continue discussion on this feature. > > > > Regards, > > Naush > > > > Naushir Patuck (3): > > libcamera: controls: Add frame duration control > > libcamera: raspberrypi: Add control of sensor vblanking > > ipa: raspberrypi: config: Update shutter speeds for imx219/477 and > > ov5647 > > > > include/libcamera/ipa/raspberrypi.h | 1 + > > src/ipa/raspberrypi/cam_helper.cpp | 38 ++++++++++++++- > > src/ipa/raspberrypi/cam_helper.hpp | 15 +++++- > > src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- > > src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 ++++- > > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 ++++- > > src/ipa/raspberrypi/data/imx219.json | 15 +++++- > > src/ipa/raspberrypi/data/imx477.json | 15 +++++- > > src/ipa/raspberrypi/data/ov5647.json | 15 +++++- > > src/ipa/raspberrypi/raspberrypi.cpp | 48 ++++++++++++++++--- > > src/libcamera/control_ids.yaml | 18 +++++++ > > .../pipeline/raspberrypi/raspberrypi.cpp | 2 + > > 12 files changed, 182 insertions(+), 20 deletions(-)
Hi Naush, On Thu, Jun 25, 2020 at 06:28:46AM +0300, Laurent Pinchart wrote: > On Wed, Jun 24, 2020 at 09:19:15AM +0100, Naushir Patuck wrote: > > Hi all, > > > > Gentle nudge to have some feedback on this please. > > I'm sorry for the delay. I'll handle this one today. I had a look at Jacopo's series that also introduces a FrameDurationLimits control first and then ran out of time :-S I'll discuss it live with Jacopo and then reply to your patches, to speed up the review process. Please bear with me for just a bit longer. > > On Mon, 8 Jun 2020 at 14:36, Naushir Patuck <naush@raspberrypi.com> wrote: > > > > > > Hi all, > > > > > > The last patch on this topic generated some useful comments. I've updated > > > the patch with the recommendations so we can continue discussion on this feature. > > > > > > Regards, > > > Naush > > > > > > Naushir Patuck (3): > > > libcamera: controls: Add frame duration control > > > libcamera: raspberrypi: Add control of sensor vblanking > > > ipa: raspberrypi: config: Update shutter speeds for imx219/477 and > > > ov5647 > > > > > > include/libcamera/ipa/raspberrypi.h | 1 + > > > src/ipa/raspberrypi/cam_helper.cpp | 38 ++++++++++++++- > > > src/ipa/raspberrypi/cam_helper.hpp | 15 +++++- > > > src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- > > > src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 ++++- > > > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 ++++- > > > src/ipa/raspberrypi/data/imx219.json | 15 +++++- > > > src/ipa/raspberrypi/data/imx477.json | 15 +++++- > > > src/ipa/raspberrypi/data/ov5647.json | 15 +++++- > > > src/ipa/raspberrypi/raspberrypi.cpp | 48 ++++++++++++++++--- > > > src/libcamera/control_ids.yaml | 18 +++++++ > > > .../pipeline/raspberrypi/raspberrypi.cpp | 2 + > > > 12 files changed, 182 insertions(+), 20 deletions(-)
Hi Laurent, On Fri, 26 Jun 2020 at 03:53, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Naush, > > On Thu, Jun 25, 2020 at 06:28:46AM +0300, Laurent Pinchart wrote: > > On Wed, Jun 24, 2020 at 09:19:15AM +0100, Naushir Patuck wrote: > > > Hi all, > > > > > > Gentle nudge to have some feedback on this please. > > > > I'm sorry for the delay. I'll handle this one today. > > I had a look at Jacopo's series that also introduces a > FrameDurationLimits control first and then ran out of time :-S I'll > discuss it live with Jacopo and then reply to your patches, to speed up > the review process. Please bear with me for just a bit longer. Thank you, yes, that makes sense. Please do not feel rushed to get this done, I was only pinging to ensure it was still on the list :) Regards, Naush > > > > On Mon, 8 Jun 2020 at 14:36, Naushir Patuck <naush@raspberrypi.com> wrote: > > > > > > > > Hi all, > > > > > > > > The last patch on this topic generated some useful comments. I've updated > > > > the patch with the recommendations so we can continue discussion on this feature. > > > > > > > > Regards, > > > > Naush > > > > > > > > Naushir Patuck (3): > > > > libcamera: controls: Add frame duration control > > > > libcamera: raspberrypi: Add control of sensor vblanking > > > > ipa: raspberrypi: config: Update shutter speeds for imx219/477 and > > > > ov5647 > > > > > > > > include/libcamera/ipa/raspberrypi.h | 1 + > > > > src/ipa/raspberrypi/cam_helper.cpp | 38 ++++++++++++++- > > > > src/ipa/raspberrypi/cam_helper.hpp | 15 +++++- > > > > src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- > > > > src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 ++++- > > > > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 ++++- > > > > src/ipa/raspberrypi/data/imx219.json | 15 +++++- > > > > src/ipa/raspberrypi/data/imx477.json | 15 +++++- > > > > src/ipa/raspberrypi/data/ov5647.json | 15 +++++- > > > > src/ipa/raspberrypi/raspberrypi.cpp | 48 ++++++++++++++++--- > > > > src/libcamera/control_ids.yaml | 18 +++++++ > > > > .../pipeline/raspberrypi/raspberrypi.cpp | 2 + > > > > 12 files changed, 182 insertions(+), 20 deletions(-) > > -- > Regards, > > Laurent Pinchart