[libcamera-devel,v3,0/8] android: Build stream configuration map

3944 mbox series

Hello,
   this series contains v2 of "android: Implement format translation" where I
have addressed Kieran's suggestions in patch 1.
Patches 2, 3 and 4 are the same as v2.

Patch 5 introduces a new property a camera can use to report it frame duration
limits. Patch 6 and 7 fill those limits by inspecting in the camera sensor
class, and patch 8 reports that duration in the android static metadata buffers.

As noted in the comments in patch 8, this is a sub-optimal approach, as the
minimum frame duration should be reported per-configuration.

Patch 5 could potentially conflict with Naush's work on frame duration. Sending
it out anyway for discussion purposed.

Tested with RPi and imx219, IPU3 with ov5670, currently failing to report
correct frame durations for ov13858. I'll investigate and fix, but I'm sending
this out earlier anyway to reduce possible conflicts.

Thanks
  j

Jacopo Mondi (8):
  android: camera_device: Initialize stream configuration
  android: camera_device: Calculate metadata size
  android: camera_device: Replace hardcoded stream configuration
  android: camera_device: Translate Android format
  libcamera: properties: Add FrameDurationLimits
  libcamera: camera_sensor: Break out properties initialization
  libcamera: camera_sensor: Initialize frame durations
  android: camera_device: Report frame durations

 include/libcamera/internal/camera_sensor.h |   2 +
 src/android/camera_device.cpp              | 349 +++++++++++++++++++--
 src/android/camera_device.h                |  15 +
 src/libcamera/camera_sensor.cpp            | 139 ++++++--
 src/libcamera/property_ids.yaml            |  47 +++
 5 files changed, 492 insertions(+), 60 deletions(-)

--
2.27.0

Hello,

On Fri, Jun 05, 2020 at 04:09:54PM +0200, Jacopo Mondi wrote:
> Hello,
>    this series contains v2 of "android: Implement format translation" where I
> have addressed Kieran's suggestions in patch 1.
> Patches 2, 3 and 4 are the same as v2.

I'm now pushing patches 1 to 4.

The part on FrameDurationLimits it's useful for discussion purposes on
the property definition but I'll try to rework it to provide
per-configuration duration limits.

Thanks
  j

>
> Patch 5 introduces a new property a camera can use to report it frame duration
> limits. Patch 6 and 7 fill those limits by inspecting in the camera sensor
> class, and patch 8 reports that duration in the android static metadata buffers.
>
> As noted in the comments in patch 8, this is a sub-optimal approach, as the
> minimum frame duration should be reported per-configuration.
>
> Patch 5 could potentially conflict with Naush's work on frame duration. Sending
> it out anyway for discussion purposed.
>
> Tested with RPi and imx219, IPU3 with ov5670, currently failing to report
> correct frame durations for ov13858. I'll investigate and fix, but I'm sending
> this out earlier anyway to reduce possible conflicts.
>
> Thanks
>   j
>
> Jacopo Mondi (8):
>   android: camera_device: Initialize stream configuration
>   android: camera_device: Calculate metadata size
>   android: camera_device: Replace hardcoded stream configuration
>   android: camera_device: Translate Android format
>   libcamera: properties: Add FrameDurationLimits
>   libcamera: camera_sensor: Break out properties initialization
>   libcamera: camera_sensor: Initialize frame durations
>   android: camera_device: Report frame durations
>
>  include/libcamera/internal/camera_sensor.h |   2 +
>  src/android/camera_device.cpp              | 349 +++++++++++++++++++--
>  src/android/camera_device.h                |  15 +
>  src/libcamera/camera_sensor.cpp            | 139 ++++++--
>  src/libcamera/property_ids.yaml            |  47 +++
>  5 files changed, 492 insertions(+), 60 deletions(-)
>
> --
> 2.27.0
>