[libcamera-devel,v2,0/4] Coverity scan fixes
mbox series

Message ID 20200515124245.18040-1-email@uajain.com
Headers show
Series
  • Coverity scan fixes
Related show

Message

Umang Jain May 15, 2020, 12:42 p.m. UTC 
Fixes of issues pointed out by coverity scans.
Some of them were reviewed earlier (attached
review tags for them) and some have been reworked
to address the review.

Umang Jain (4):
  test: ipc: unixsocket: Close open fds on error paths
  test: log: log_process: Close open fds on error paths
  test: log: log_api: Close open fds on error paths
  libcamera: camera: Return -EINVAL if any stream is null while
    configure()

 src/libcamera/camera.cpp | 5 ++++-
 test/ipc/unixsocket.cpp  | 2 ++
 test/log/log_api.cpp     | 2 ++
 test/log/log_process.cpp | 1 +
 4 files changed, 9 insertions(+), 1 deletion(-)

Comments

Kieran Bingham June 2, 2020, 9:43 a.m. UTC | #1 
Hi Umang,

These all look good to me. I've updated the coverity tagging style to
match Laurent's usage (not your fault, as we haven't really declared the
style of reporting that yet)

I've got them applied to a local branch, and they pass the tests, so if
there are no further comments I'll push these to master today.

Thank you,

Kieran


On 15/05/2020 13:42, Umang Jain wrote:
> Fixes of issues pointed out by coverity scans.
> Some of them were reviewed earlier (attached
> review tags for them) and some have been reworked
> to address the review.
> 
> Umang Jain (4):
>   test: ipc: unixsocket: Close open fds on error paths
>   test: log: log_process: Close open fds on error paths
>   test: log: log_api: Close open fds on error paths
>   libcamera: camera: Return -EINVAL if any stream is null while
>     configure()
> 
>  src/libcamera/camera.cpp | 5 ++++-
>  test/ipc/unixsocket.cpp  | 2 ++
>  test/log/log_api.cpp     | 2 ++
>  test/log/log_process.cpp | 1 +
>  4 files changed, 9 insertions(+), 1 deletion(-)
>
Umang Jain June 2, 2020, 3:04 p.m. UTC | #2 
Hi Kieran,

On 6/2/20 3:13 PM, Kieran Bingham wrote:
> Hi Umang,
>
> These all look good to me. I've updated the coverity tagging style to
> match Laurent's usage (not your fault, as we haven't really declared the
> style of reporting that yet)
Ah, I have taken note of this for future references.
>
> I've got them applied to a local branch, and they pass the tests, so if
> there are no further comments I'll push these to master today.
No further comments. Thanks for the review.
> Thank you,
>
> Kieran
>
>
> On 15/05/2020 13:42, Umang Jain wrote:
>> Fixes of issues pointed out by coverity scans.
>> Some of them were reviewed earlier (attached
>> review tags for them) and some have been reworked
>> to address the review.
>>
>> Umang Jain (4):
>>    test: ipc: unixsocket: Close open fds on error paths
>>    test: log: log_process: Close open fds on error paths
>>    test: log: log_api: Close open fds on error paths
>>    libcamera: camera: Return -EINVAL if any stream is null while
>>      configure()
>>
>>   src/libcamera/camera.cpp | 5 ++++-
>>   test/ipc/unixsocket.cpp  | 2 ++
>>   test/log/log_api.cpp     | 2 ++
>>   test/log/log_process.cpp | 1 +
>>   4 files changed, 9 insertions(+), 1 deletion(-)
>>