[libcamera-devel,0/2] meson: Check on required python modules
mbox series

Message ID 20200414180229.10320-1-ariel@vanguardiasur.com.ar
Headers show
Series
  • meson: Check on required python modules
Related show

Message

Ariel D'Alessandro April 14, 2020, 6:02 p.m. UTC 
Hi all,

This small patch series adds python module dependencies check, required
to run a few python scripts during build.

Thanks,

Ariel D'Alessandro (2):
  meson: Bump required version to 0.51
  libcamera: meson: Add check on required python modules

 include/libcamera/meson.build | 1 +
 meson.build                   | 4 +++-
 src/libcamera/meson.build     | 1 +
 3 files changed, 5 insertions(+), 1 deletion(-)

Comments

Laurent Pinchart April 14, 2020, 8:10 p.m. UTC | #1 
Hi Ariel,

Thank you for the patches.

On Tue, Apr 14, 2020 at 03:02:27PM -0300, Ariel D'Alessandro wrote:
> Hi all,
> 
> This small patch series adds python module dependencies check, required
> to run a few python scripts during build.

Ezequiel has sent a similar patch series previously, which I have
temporarily pushed against. I would like, unless we really can't do
otherwise, to not depend on a meson version newer than what is shipped
by the latest release of major distributions. The intent is to keep it
easy for people to compile libcamera. Of course, if I'm mistaken in my
assumption that people would generally prefer to stick with what their
distribution ship, or if newer meson features would outweight this
convenience requirement, we could upgrade to a newer version sooner.

> Ariel D'Alessandro (2):
>   meson: Bump required version to 0.51
>   libcamera: meson: Add check on required python modules
> 
>  include/libcamera/meson.build | 1 +
>  meson.build                   | 4 +++-
>  src/libcamera/meson.build     | 1 +
>  3 files changed, 5 insertions(+), 1 deletion(-)
>
Ariel D'Alessandro April 14, 2020, 8:57 p.m. UTC | #2 
Hi Laurent,

On 4/14/20 5:10 PM, Laurent Pinchart wrote:
> Hi Ariel,
> 
> Thank you for the patches.
> 
> On Tue, Apr 14, 2020 at 03:02:27PM -0300, Ariel D'Alessandro wrote:
>> Hi all,
>>
>> This small patch series adds python module dependencies check, required
>> to run a few python scripts during build.
> 
> Ezequiel has sent a similar patch series previously, which I have
> temporarily pushed against. I would like, unless we really can't do
> otherwise, to not depend on a meson version newer than what is shipped
> by the latest release of major distributions. The intent is to keep it
> easy for people to compile libcamera. Of course, if I'm mistaken in my
> assumption that people would generally prefer to stick with what their
> distribution ship, or if newer meson features would outweight this
> convenience requirement, we could upgrade to a newer version sooner.

Oops, didn't see the previous patch from Ezequiel. Sorry for the noise then.

Regards,