[libcamera-devel,0/7] libcamera: Add support for a RAW still capture
mbox series

Message ID 20200324155145.3896183-1-niklas.soderlund@ragnatech.se
Headers show
Series
  • libcamera: Add support for a RAW still capture
Related show

Message

Niklas Söderlund March 24, 2020, 3:51 p.m. UTC
Hi,

This series adds RAW capture support. It implements a RAW stream in the 
IPU3 pipeline handler as an example. It targets RAW still image captures 
and uses a memcpy to copy out the buffer with the RAW data as soon as 
it's dequeued from the CIO2. The copy is needed as the buffer might need 
to be used in further processing by the IMGU.

Patch 1/7 Defines a new StillCaptureRaw role which can be used to
applications to generate configurations for raw capture. Patch 2/7 makes
use of this new role in the cam utility.

Patch 3/7 is not ready for consumption as it depends on work submitted
to the DRM subsystem. The patch is however needed as the new DRM formats
are needed to describe the IPU3's RAW pixel format.

Patch 4/7 adds a helper to do the actual memcpy of FrameBuffers. Patch 
5/7 adds a way for pipelines to set a FrameBuffer Request *. Patch 6/7 
and 7/7 deals with implementing the RAW stream into the IPU3 pipeline 
handler.

I have tested this on IPU3 and I can capture both a single RAW stream or
a mix of RAW and video, example with both and writing to disk.

$ ./cam -c1  -s role=video -s role=stillraw -C -F
...
fps: 0.00 stream0 seq: 002055 bytesused: 1382400 stream1 seq: 000001 bytesused: 3269376
fps: 30.30 stream0 seq: 002056 bytesused: 1382400 stream1 seq: 000002 bytesused: 3269376
fps: 30.30 stream0 seq: 002057 bytesused: 1382400 stream1 seq: 000003 bytesused: 3269376
fps: 30.30 stream0 seq: 002058 bytesused: 1382400 stream1 seq: 000004 bytesused: 3269376
...

I have also verified the content of the captured RAW frames have the 
expected content.

Niklas Söderlund (7):
  libcamera: stream: Add StillCaptureRaw role
  cam: Add option to capture StillCaptureRaw stream
  [DNI] include: drm_fourcc: Add Bayer FourCC and modifiers
  libcamera: FrameBuffer: Add a method to copy buffer content
  libcamera: FrameBuffer: Add a setRequest() interface
  libcamera: ipu3: Do not unconditionally queue buffers to CIO2
  libcamera: ipu3: Add support for a RAW still capture stream

 include/libcamera/buffer.h           |   4 +-
 include/libcamera/stream.h           |   1 +
 include/linux/drm_fourcc.h           |  94 +++++++++++++++++
 src/cam/main.cpp                     |   4 +-
 src/libcamera/buffer.cpp             |  72 +++++++++++++
 src/libcamera/pipeline/ipu3/ipu3.cpp | 152 +++++++++++++++++++++++----
 src/libcamera/stream.cpp             |   3 +
 7 files changed, 309 insertions(+), 21 deletions(-)