[libcamera-devel,v2,0/2] Add a V4L2PixelFormat class
mbox series

Message ID 20200319023149.32195-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • Add a V4L2PixelFormat class
Related show

Message

Laurent Pinchart March 19, 2020, 2:31 a.m. UTC 
Hello,

This small patch series builds on top of Niklas' PixelFormat work to
introduce the V4L2 counterpart of the PixelFormat class. Compared to v1,
a toString() method has been aded.

The class should be extended for a lookup table of pixel format names to
improve the toString() method. Other helper methods to retrieve format
information should probably be added too, hopefully removing some of the
data from the pixelFormatInfo array in v4l2_camera_proxy. Ideas on how
to split pixel format information and conversion between the
PixelFormat, V4L2PixelFormat and V4L2VideoDevice classes are welcome.

Laurent Pinchart (2):
  libcamera: v4l2_videodevice: Add V4L2PixelFormat class
  libcamera: v4l2_videodevice: Make V4L2PixelFormat constructor explicit

 src/libcamera/include/v4l2_videodevice.h      |  39 ++++--
 src/libcamera/pipeline/ipu3/ipu3.cpp          |  14 +-
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      |   4 +-
 src/libcamera/pipeline/uvcvideo.cpp           |   4 +-
 src/libcamera/pipeline/vimc.cpp               |   2 +-
 src/libcamera/v4l2_videodevice.cpp            | 125 +++++++++++++-----
 .../v4l2_videodevice_test.cpp                 |   2 +-
 7 files changed, 135 insertions(+), 55 deletions(-)