[libcamera-devel,0/2] Add a V4L2PixelFormat class
mbox series

Message ID 20200316234649.2545-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • Add a V4L2PixelFormat class
Related show

Message

Laurent Pinchart March 16, 2020, 11:46 p.m. UTC 
Hello,

This small patch series builds on top of Niklas' PixelFormat work to
introduce the V4L2 counterpart of the PixelFormat class.

I've experimented with adding an implicit conversion from
V4L2PixelFormat to uint32_t, which could possibly be useful for
PixelFormat too as an alternate method to retrieve the FourCC. It likely
makes sense to provide this for both classes, or for neither of them.

A toString() method should be added, with a lookup table of pixel format
names. Other helper methods to retrieve format information should
probably be added too, hopefully removing some of the data from the
pixelFormatInfo array in v4l2_camera_proxy. Ideas on how to split pixel
format information and conversion between the PixelFormat,
V4L2PixelFormat and V4L2VideoDevice classes are welcome.

Laurent Pinchart (2):
  libcamera: v4l2_videodevice: Add V4L2PixelFormat class
  libcamera: v4l2_videodevice: Make V4L2PixelFormat constructor explicit

 src/libcamera/include/v4l2_videodevice.h      |  35 ++++--
 src/libcamera/pipeline/ipu3/ipu3.cpp          |  14 +--
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      |   4 +-
 src/libcamera/pipeline/vimc.cpp               |   2 +-
 src/libcamera/v4l2_videodevice.cpp            | 104 +++++++++++++-----
 .../v4l2_videodevice_test.cpp                 |   2 +-
 6 files changed, 113 insertions(+), 48 deletions(-)