[v2,0/3] libcamera: rkisp1: Camera Sensor Mode Validation
mbox series

Message ID 20261102-kbingham-orientation-v2-0-21b1cdd0d167@ideasonboard.com
Headers show
Series
  • libcamera: rkisp1: Camera Sensor Mode Validation
Related show

Message

Kieran Bingham Nov. 2, 2026, 12:11 p.m. UTC 
While testing the RKISP1 with dewarp features enabled, it is possible to
have a camera with a default 90* rotation.  During testing it becomes
very easy to transpose the width and height - which can lead to asking
for an invalid camera configuration.

This demonstrated itself as a configuration that was successfully
validated, but that could never successfully configure.

Expand the CameraSensor classes to aid reporting this instance to the
user, and ensure that if an invalid sensor configuration is selected
that the Configuration is rejected as Invalid.

Further extend the 'cam' tool to support setting the
rotation(Orientations) accordingly which then allows the desired
configuration to be tested correctly.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
Kieran Bingham (3):
      libcamera: pipeline: rkisp1: Detect invalid sensor configurations
      libcamera: camera_sensor: Extend reporting in getFormat()
      apps: cam: Support full orientation options

 src/apps/cam/camera_session.cpp               |  9 +++++++++
 src/apps/cam/main.cpp                         |  5 ++++-
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      | 12 ++++++++++++
 src/libcamera/sensor/camera_sensor_legacy.cpp |  4 +++-
 src/libcamera/sensor/camera_sensor_raw.cpp    |  4 +++-
 5 files changed, 31 insertions(+), 3 deletions(-)
---
base-commit: df8e348d64b4932a0676256ed24f0da3ee9438bc
change-id: 20261102-kbingham-orientation-421ddf0f9589

Best regards,