| Message ID | 20260928-awb-state-v1-0-9b1bb8b9e51b@ideasonboard.com |
|---|---|
| Headers | show
Return-Path: <libcamera-devel-bounces@lists.libcamera.org> X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3E828BDCBC for <parsemail@patchwork.libcamera.org>; Mon, 28 Sep 2026 11:14:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9C16068A55; Mon, 28 Sep 2026 13:14:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="E/ym7cEL"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B30F668A0C for <libcamera-devel@lists.libcamera.org>; Mon, 28 Sep 2026 13:14:14 +0200 (CEST) Received: from [127.0.1.1] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4067AB07; Mon, 28 Sep 2026 13:12:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1790593944; bh=t42zDzNqJe/HzimVcwPUcZakimiLTP6h2dj80TqzXA4=; h=From:Subject:Date:To:Cc:From; b=E/ym7cELbp0fSAk76O7CjOgGBjR2VnFbSU0ko76t32GxXN1vlfCOm6vMI6mQyHEa4 7bgMrrAhwGQCqQGr5R5EUPaqT2haxmuv5WkqJhxTsCHmtR+gHm1jS7+wUCGre/+1At ZcqAXq6c93qIwN6NOxi8nHkRW0ilLaL/Q3IdkWCY= From: Daniel Scally <dan.scally@ideasonboard.com> Subject: [PATCH 0/5] Add AwbState metadata and AwbTrigger control Date: Mon, 28 Sep 2026 12:13:56 +0100 Message-Id: <20260928-awb-state-v1-0-9b1bb8b9e51b@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAPVLumoC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDCwNT3cTyJN3iksSSVF1Ts2SzRJM0S9NEIxMloPqCotS0zAqwWdGxtbU A9jyVFVsAAAA= X-Change-ID: 20260805-awb-state-56c6a4f95a24 To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally <dan.scally@ideasonboard.com> X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2285; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=t42zDzNqJe/HzimVcwPUcZakimiLTP6h2dj80TqzXA4=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqukv9veLHBeW2GOtfMY++accCptQ3EsNZw07YE OOB+JfSqy2JAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCarpL/QAKCRDISVd6bEV1 MluQD/sEayRCR5e9utmbq7VRJvZwrfz96S+L0EmbKmJTqbk3UPzIJTx900rx9V0xyeACDGY1iR6 mtMHWSUGg/+X+W6ancjAHCTv/IwP4JKktphALnQ3Y/hu06NJaJO36e5xOa0+O7TB8uVSMZCPEhf teU4XfBcx+3U0fzUQ8lBla1Qu1BWq4tGiEv1/2Ipf+bx3MUVBuUQoQMKuZ8bvVpAT3VSdVCzCtZ CrEXx6QPoaJmFqQmgd5YFwmREcd2WubTmCWNTcSeTkGHwtYlAEvcCxlAhsEzgcQf9QCeeydTHTR 9aT/jzl10F6i6KpL8pCOJgiwjgHMc227gPUqBEcgzLKxUVaHhwPDqgF73m0pgBcp+oOWhohYtU0 gWVGSwgURdN0XviPG1UYqSDP+3J9zmXJBuRp7q9Igl44ozxoayV8G5pg8aZOjp8fXQaVrUvbD0U QtHYqTyEpnUwiCfXce81RV0V30NPRPbXVH2QyzBQM51wnYSosiLIAmjKYh41Nb9Ac4l8EfYJHzx GMOvZ20K1o+CVUyDBzOmnPAMmoAgJHgO0Mp0Zj/bVfSqOj2bE3BIf8j6/AcEwHsTnJrgI7rGgcv 7qSJ6LGRh2cuormdDWOJoVPqa6xiV8jl6AmhwgREVc2S2TEPBbY6bmddAzTCSrfiLS3QnapTjUY yf3V2LoXRlXQ3iA== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org> |
| Series |
|
| Related | show |
Hello This series adds a mode of operation to the AWB algorithm such that the calculated gains can be "frozen" at a particular point, but later prompted to re-calculate and then to re-freeze with a single control. The main changes are: 1. The Awb algorithm's manual gains are updated from the automatic gains whenever AwbEnable == true. This means that setting AwbEnable = False will result in the gains "freezing" rather than jumping to the last-set manual values (unless a new set of values is passed at the same time). 2. The AwbLocked metadata item, which has no users, is removed. 3. A new metadata item named AwbState is added. This reports either "Locked" when AwbEnable is false, or "Searching" when the gains that the algorithm calculates for a frame are sufficiently changed from those previously calculated, or else "Converged". 4. A new control called AwbTrigger is added. This control is intended to be used only when AwbEnable == false (and therefore AwbState is "Locked"). When this control is passed with a request, AwbState will be reported as "Searching" until the algorithm converges, at which point the state returns to Locked and the manual gains are updated with the converged gains. The change also brings the behaviour more in line with the Auto-focus controls, which have a similar concept of operation. Thanks Dan Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> --- Daniel Scally (5): libcamera: controls: Expand AWB controls libcamera: vector: Add more comparison operators ipa: libipa: awb: Report AwbState ipa: libipa: awb: Update manual gains with automatic ipa: libipa: awb: Add AwbTrigger control include/libcamera/internal/vector.h | 44 +++++++++++++++++ src/ipa/libipa/awb.cpp | 93 ++++++++++++++++++++++++++++++++++-- src/ipa/libipa/awb.h | 6 +++ src/libcamera/control_ids_core.yaml | 44 ++++++++++++++--- src/libcamera/control_ids_draft.yaml | 22 --------- 5 files changed, 176 insertions(+), 33 deletions(-) --- base-commit: 0024628dae48701da79e7522c8a057ba6a855201 change-id: 20260805-awb-state-56c6a4f95a24 Best regards,