[v3,0/3] Clarify rectangle behavior
mbox series

Message ID 20260908135949.3842255-1-stefan.klug@ideasonboard.com
Headers show
Series
  • Clarify rectangle behavior
Related show

Message

Stefan Klug Sept. 8, 2026, 1:56 p.m. UTC 
Hi all,

This series changes the behavior of PixelArraySize to represent the
physical sensor area instead of the readable pixel area. The reasoning
is explained in a bit more detail in patch 1. Patch 2 applies that idea
to the IPA interface. Patch 3 adds an additional property for
completeness sake which we could drop.

With these patches applied I am able to draw proper bounding rectangles
in camshark. An implemented is available in
https://gitlab.freedesktop.org/camera/camshark/-/tree/sklug/next?ref_type=heads

Best regards,
Stefan

Version 3 prevents negative crop rectangles in the rpi ipa and issues a
warning in that case. Aside from that a few minor stylistic fixes from
the review were applied.

Stefan Klug (3):
  libcamera: Clarify meaning of PixelArraySize and other rectangles
  libcamera: ipa: core: Use native coordinates for
    IPACameraSensorInfo::analogCrop
  libcamera: ipa: core: Add IPACameraSensorInfo::pixelArraySize property

 include/libcamera/ipa/core.mojom              |  35 +++--
 src/ipa/mali-c55/algorithms/lsc.cpp           |   2 +-
 src/ipa/rkisp1/algorithms/lsc.cpp             |   2 +-
 src/ipa/rpi/common/ipa_base.cpp               |  20 ++-
 src/libcamera/property_ids_core.yaml          | 123 ++++++++++--------
 src/libcamera/sensor/camera_sensor_legacy.cpp |  35 ++---
 src/libcamera/sensor/camera_sensor_raw.cpp    |  30 +++--
 7 files changed, 148 insertions(+), 99 deletions(-)