| Message ID | 20260717134634.2578897-1-naush@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Naushir, On 17.07.26 15:42, Naushir Patuck wrote: > Hi, > > As the title says, this series adds support for the Sony IMX355 sensor tree-wide > and RPi tunings. This has been tested with the latest sensor driver patches > that have been posted on linux-media [1]. > > Regards, > Naush > > [1] https://lore.kernel.org/linux-media/20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com/ nice, it makes me super happy to see this! Why? Because the IMX355 also happens the front camera of the Pixel3a, one the best supported linux-mobile devices currently available. That's on a qcom SoC - i.e. using the softISP. Having the cam helper as well as the RPi tuning file (and of course the kernel driver being in much better shape) should allow us to ship a first upstream tuning file for the simple pipeline, using the same CCMs. I just tested that and it looks pretty good! Further more it should allow us to test/verify the "LSC for SoftISP simple pipeline" series (https://patchwork.libcamera.org/cover/27368/). So thanks a lot and I hope both this series and the kernel patches will land soon! Robert > > Naushir Patuck (2): > libcamera: camera_sensor: Add Sony IMX355 sensor properties and helper > ipa: rpi: Add support for Sony IMX355 > > src/ipa/libipa/camera_sensor_helper.cpp | 12 + > src/ipa/rpi/cam_helper/cam_helper_imx355.cpp | 69 + > src/ipa/rpi/cam_helper/meson.build | 1 + > src/ipa/rpi/pisp/data/imx355.json | 1233 +++++++++++++++++ > src/ipa/rpi/pisp/data/meson.build | 1 + > src/ipa/rpi/vc4/data/imx355.json | 416 ++++++ > .../sensor/camera_sensor_properties.cpp | 16 + > 7 files changed, 1748 insertions(+) > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx355.cpp > create mode 100644 src/ipa/rpi/pisp/data/imx355.json > create mode 100644 src/ipa/rpi/vc4/data/imx355.json >
Hi Robert , Happy to hear this work helps you! On Fri, 17 Jul 2026, 4:28 pm Robert Mader, <robert.mader@collabora.com> wrote: > Hi Naushir, > > On 17.07.26 15:42, Naushir Patuck wrote: > > Hi, > > > > As the title says, this series adds support for the Sony IMX355 sensor > tree-wide > > and RPi tunings. This has been tested with the latest sensor driver > patches > > that have been posted on linux-media [1]. > > > > Regards, > > Naush > > > > [1] > https://lore.kernel.org/linux-media/20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com/ > > nice, it makes me super happy to see this! Why? Because the IMX355 also > happens the front camera of the Pixel3a, one the best supported > linux-mobile devices currently available. That's on a qcom SoC - i.e. > using the softISP. Having the cam helper as well as the RPi tuning file > (and of course the kernel driver being in much better shape) should > allow us to ship a first upstream tuning file for the simple pipeline, > using the same CCMs. I just tested that and it looks pretty good! Feel free to add a Tested-by (with caveats) if you are happy to do so ;-) Naush > Further more it should allow us to test/verify the "LSC for SoftISP > simple pipeline" series (https://patchwork.libcamera.org/cover/27368/). > > So thanks a lot and I hope both this series and the kernel patches will > land soon! > > Robert > > > > > Naushir Patuck (2): > > libcamera: camera_sensor: Add Sony IMX355 sensor properties and helper > > ipa: rpi: Add support for Sony IMX355 > > > > src/ipa/libipa/camera_sensor_helper.cpp | 12 + > > src/ipa/rpi/cam_helper/cam_helper_imx355.cpp | 69 + > > src/ipa/rpi/cam_helper/meson.build | 1 + > > src/ipa/rpi/pisp/data/imx355.json | 1233 +++++++++++++++++ > > src/ipa/rpi/pisp/data/meson.build | 1 + > > src/ipa/rpi/vc4/data/imx355.json | 416 ++++++ > > .../sensor/camera_sensor_properties.cpp | 16 + > > 7 files changed, 1748 insertions(+) > > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx355.cpp > > create mode 100644 src/ipa/rpi/pisp/data/imx355.json > > create mode 100644 src/ipa/rpi/vc4/data/imx355.json > > > -- > Robert Mader > Consultant Software Developer > > Collabora Ltd. > Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK > Registered in England & Wales, no. 5513718 > >
Hi Naush, On 17.07.26 17:35, Naushir Patuck wrote: > Hi Robert , > > Happy to hear this work helps you! > > > On Fri, 17 Jul 2026, 4:28 pm Robert Mader, > <robert.mader@collabora.com> wrote: > > Hi Naushir, > > On 17.07.26 15:42, Naushir Patuck wrote: > > Hi, > > > > As the title says, this series adds support for the Sony IMX355 > sensor tree-wide > > and RPi tunings. This has been tested with the latest sensor > driver patches > > that have been posted on linux-media [1]. > > > > Regards, > > Naush > > > > [1] > https://lore.kernel.org/linux-media/20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com/ > > nice, it makes me super happy to see this! Why? Because the IMX355 > also > happens the front camera of the Pixel3a, one the best supported > linux-mobile devices currently available. That's on a qcom SoC - i.e. > using the softISP. Having the cam helper as well as the RPi tuning > file > (and of course the kernel driver being in much better shape) should > allow us to ship a first upstream tuning file for the simple > pipeline, > using the same CCMs. I just tested that and it looks pretty good! > > > Feel free to add a Tested-by (with caveats) if you are happy to do so ;-) sure, done! Which leaves me with one humble request to you: assuming you took some raw images for the CCM tuning (and also for LSC?) - would you consider contributing them to the in-development tuning repo at https://gitlab.freedesktop.org/camera/tuning/ (using CC-BY-SA 4.0), allowing us to re-create the tuning data from the source? That's of course completely optional - but a super helpful step for us to move the softISP forward (which will hopefully also help validating/testing the RPi backend in the future, just like llvmpipe in Mesa). Best regards, Robert > > Naush > > > Further more it should allow us to test/verify the "LSC for SoftISP > simple pipeline" series > (https://patchwork.libcamera.org/cover/27368/). > > So thanks a lot and I hope both this series and the kernel patches > will > land soon! > > Robert > > > > > Naushir Patuck (2): > > libcamera: camera_sensor: Add Sony IMX355 sensor properties > and helper > > ipa: rpi: Add support for Sony IMX355 > > > > src/ipa/libipa/camera_sensor_helper.cpp | 12 + > > src/ipa/rpi/cam_helper/cam_helper_imx355.cpp | 69 + > > src/ipa/rpi/cam_helper/meson.build | 1 + > > src/ipa/rpi/pisp/data/imx355.json | 1233 > +++++++++++++++++ > > src/ipa/rpi/pisp/data/meson.build | 1 + > > src/ipa/rpi/vc4/data/imx355.json | 416 ++++++ > > .../sensor/camera_sensor_properties.cpp | 16 + > > 7 files changed, 1748 insertions(+) > > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx355.cpp > > create mode 100644 src/ipa/rpi/pisp/data/imx355.json > > create mode 100644 src/ipa/rpi/vc4/data/imx355.json > > > -- > Robert Mader > Consultant Software Developer > > Collabora Ltd. > Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK > Registered in England & Wales, no. 5513718 >
Hi Robert, On Fri, 17 Jul 2026 at 17:07, Robert Mader <robert.mader@collabora.com> wrote: > > Hi Naush, > > On 17.07.26 17:35, Naushir Patuck wrote: > > Hi Robert , > > Happy to hear this work helps you! > > > On Fri, 17 Jul 2026, 4:28 pm Robert Mader, <robert.mader@collabora.com> wrote: >> >> Hi Naushir, >> >> On 17.07.26 15:42, Naushir Patuck wrote: >> > Hi, >> > >> > As the title says, this series adds support for the Sony IMX355 sensor tree-wide >> > and RPi tunings. This has been tested with the latest sensor driver patches >> > that have been posted on linux-media [1]. >> > >> > Regards, >> > Naush >> > >> > [1] https://lore.kernel.org/linux-media/20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com/ >> >> nice, it makes me super happy to see this! Why? Because the IMX355 also >> happens the front camera of the Pixel3a, one the best supported >> linux-mobile devices currently available. That's on a qcom SoC - i.e. >> using the softISP. Having the cam helper as well as the RPi tuning file >> (and of course the kernel driver being in much better shape) should >> allow us to ship a first upstream tuning file for the simple pipeline, >> using the same CCMs. I just tested that and it looks pretty good! > > > Feel free to add a Tested-by (with caveats) if you are happy to do so ;-) > > sure, done! Which leaves me with one humble request to you: assuming you took some raw images for the CCM tuning (and also for LSC?) - would you consider contributing them to the in-development tuning repo at https://gitlab.freedesktop.org/camera/tuning/ (using CC-BY-SA 4.0), allowing us to re-create the tuning data from the source? That's of course completely optional - but a super helpful step for us to move the softISP forward (which will hopefully also help validating/testing the RPi backend in the future, just like llvmpipe in Mesa). This might be possible, but I will need to speak with the management to confirm they are ok with it. Regards, Naush > > Best regards, > > Robert > > > Naush > >> >> Further more it should allow us to test/verify the "LSC for SoftISP >> simple pipeline" series (https://patchwork.libcamera.org/cover/27368/). >> >> So thanks a lot and I hope both this series and the kernel patches will >> land soon! >> >> Robert >> >> > >> > Naushir Patuck (2): >> > libcamera: camera_sensor: Add Sony IMX355 sensor properties and helper >> > ipa: rpi: Add support for Sony IMX355 >> > >> > src/ipa/libipa/camera_sensor_helper.cpp | 12 + >> > src/ipa/rpi/cam_helper/cam_helper_imx355.cpp | 69 + >> > src/ipa/rpi/cam_helper/meson.build | 1 + >> > src/ipa/rpi/pisp/data/imx355.json | 1233 +++++++++++++++++ >> > src/ipa/rpi/pisp/data/meson.build | 1 + >> > src/ipa/rpi/vc4/data/imx355.json | 416 ++++++ >> > .../sensor/camera_sensor_properties.cpp | 16 + >> > 7 files changed, 1748 insertions(+) >> > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx355.cpp >> > create mode 100644 src/ipa/rpi/pisp/data/imx355.json >> > create mode 100644 src/ipa/rpi/vc4/data/imx355.json >> > >> -- >> Robert Mader >> Consultant Software Developer >> >> Collabora Ltd. >> Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK >> Registered in England & Wales, no. 5513718 >> > -- > Robert Mader > Consultant Software Developer > > Collabora Ltd. > Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK > Registered in England & Wales, no. 5513718
Hi Robert On Fri, 17 Jul 2026 at 16:28, Robert Mader <robert.mader@collabora.com> wrote: > > Hi Naushir, > > On 17.07.26 15:42, Naushir Patuck wrote: > > Hi, > > > > As the title says, this series adds support for the Sony IMX355 sensor tree-wide > > and RPi tunings. This has been tested with the latest sensor driver patches > > that have been posted on linux-media [1]. > > > > Regards, > > Naush > > > > [1] https://lore.kernel.org/linux-media/20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com/ > > nice, it makes me super happy to see this! Why? Because the IMX355 also > happens the front camera of the Pixel3a, one the best supported > linux-mobile devices currently available. That's on a qcom SoC - i.e. > using the softISP. Having the cam helper as well as the RPi tuning file > (and of course the kernel driver being in much better shape) should > allow us to ship a first upstream tuning file for the simple pipeline, > using the same CCMs. I just tested that and it looks pretty good! > Further more it should allow us to test/verify the "LSC for SoftISP > simple pipeline" series (https://patchwork.libcamera.org/cover/27368/). > > So thanks a lot and I hope both this series and the kernel patches will > land soon! I received the notification on Saturday that Sakari has merged the kernel patches to media.git/next, so all being well I'd hope they will be in 7.3 :-) David Heidelberg's patch adding support for a 24MHz clock is the main one needed for both Pixel3a and the module I've been looking at, but the rest are useful clean ups and additional features to make it work nicely with libcamera. Dave > Robert > > > > > Naushir Patuck (2): > > libcamera: camera_sensor: Add Sony IMX355 sensor properties and helper > > ipa: rpi: Add support for Sony IMX355 > > > > src/ipa/libipa/camera_sensor_helper.cpp | 12 + > > src/ipa/rpi/cam_helper/cam_helper_imx355.cpp | 69 + > > src/ipa/rpi/cam_helper/meson.build | 1 + > > src/ipa/rpi/pisp/data/imx355.json | 1233 +++++++++++++++++ > > src/ipa/rpi/pisp/data/meson.build | 1 + > > src/ipa/rpi/vc4/data/imx355.json | 416 ++++++ > > .../sensor/camera_sensor_properties.cpp | 16 + > > 7 files changed, 1748 insertions(+) > > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx355.cpp > > create mode 100644 src/ipa/rpi/pisp/data/imx355.json > > create mode 100644 src/ipa/rpi/vc4/data/imx355.json > > > -- > Robert Mader > Consultant Software Developer > > Collabora Ltd. > Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK > Registered in England & Wales, no. 5513718 >
Hi Dave, On 20.07.26 15:29, Dave Stevenson wrote: > Hi Robert > > On Fri, 17 Jul 2026 at 16:28, Robert Mader <robert.mader@collabora.com> wrote: >> Hi Naushir, >> >> On 17.07.26 15:42, Naushir Patuck wrote: >>> Hi, >>> >>> As the title says, this series adds support for the Sony IMX355 sensor tree-wide >>> and RPi tunings. This has been tested with the latest sensor driver patches >>> that have been posted on linux-media [1]. >>> >>> Regards, >>> Naush >>> >>> [1] https://lore.kernel.org/linux-media/20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com/ >> nice, it makes me super happy to see this! Why? Because the IMX355 also >> happens the front camera of the Pixel3a, one the best supported >> linux-mobile devices currently available. That's on a qcom SoC - i.e. >> using the softISP. Having the cam helper as well as the RPi tuning file >> (and of course the kernel driver being in much better shape) should >> allow us to ship a first upstream tuning file for the simple pipeline, >> using the same CCMs. I just tested that and it looks pretty good! >> Further more it should allow us to test/verify the "LSC for SoftISP >> simple pipeline" series (https://patchwork.libcamera.org/cover/27368/). >> >> So thanks a lot and I hope both this series and the kernel patches will >> land soon! > I received the notification on Saturday that Sakari has merged the > kernel patches to media.git/next, so all being well I'd hope they will > be in 7.3 :-) > > David Heidelberg's patch adding support for a 24MHz clock is the main > one needed for both Pixel3a and the module I've been looking at, but > the rest are useful clean ups and additional features to make it work > nicely with libcamera. I suppose that should be enough to already land this series? The second/RPi-specific patch still misses a R-B, though. P.S.: I tested the softISP without you kernel patches and it worked well, so I guess things will only get better. Best regards, Robert > > Dave > >> Robert >> >>> Naushir Patuck (2): >>> libcamera: camera_sensor: Add Sony IMX355 sensor properties and helper >>> ipa: rpi: Add support for Sony IMX355 >>> >>> src/ipa/libipa/camera_sensor_helper.cpp | 12 + >>> src/ipa/rpi/cam_helper/cam_helper_imx355.cpp | 69 + >>> src/ipa/rpi/cam_helper/meson.build | 1 + >>> src/ipa/rpi/pisp/data/imx355.json | 1233 +++++++++++++++++ >>> src/ipa/rpi/pisp/data/meson.build | 1 + >>> src/ipa/rpi/vc4/data/imx355.json | 416 ++++++ >>> .../sensor/camera_sensor_properties.cpp | 16 + >>> 7 files changed, 1748 insertions(+) >>> create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx355.cpp >>> create mode 100644 src/ipa/rpi/pisp/data/imx355.json >>> create mode 100644 src/ipa/rpi/vc4/data/imx355.json >>> >> -- >> Robert Mader >> Consultant Software Developer >> >> Collabora Ltd. >> Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK >> Registered in England & Wales, no. 5513718 >>