[0/4] libcamera: Improve shader header generation
mbox series

Message ID 20260630083031.3197714-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: Improve shader header generation
Related show

Message

Laurent Pinchart June 30, 2026, 8:30 a.m. UTC 
Hello,

I found a cleanup branch in my tree that I had forgotten to send out.
Here it is after a rebase.

The goal was to use std::array in the generated shader header. This is
done in patch 4/4. As a byproduct, I ended up simplifying the generation
by merging the two scripts into one (2/4) and moving the build logic
(1/4) and generation script (3/4) to the right location.


Laurent Pinchart (4):
  libcamera: shaders: Move header generation to shaders directory
  utils: Merge shader header generation scripts
  utils: Rename and move shader header generation script
  libcamera: shaders: Replace C array with std::array

 src/libcamera/meson.build                  | 10 ---
 src/libcamera/shaders/meson.build          | 10 +++
 src/libcamera/software_isp/debayer_egl.cpp | 25 +++-----
 utils/codegen/gen-shader-header.py         | 72 ++++++++++++++++++++++
 utils/codegen/meson.build                  |  1 +
 utils/gen-shader-header.py                 | 37 -----------
 utils/gen-shader-headers.sh                | 54 ----------------
 utils/meson.build                          |  2 -
 8 files changed, 91 insertions(+), 120 deletions(-)
 create mode 100755 utils/codegen/gen-shader-header.py
 delete mode 100755 utils/gen-shader-header.py
 delete mode 100755 utils/gen-shader-headers.sh


base-commit: 7a033dbdd4ca29cca2ef7eb144f6a6f57979b70d

Comments

Laurent Pinchart June 30, 2026, 8:47 a.m. UTC | #1 
On Tue, Jun 30, 2026 at 11:30:27AM +0300, Laurent Pinchart wrote:
> Hello,
> 
> I found a cleanup branch in my tree that I had forgotten to send out.
> Here it is after a rebase.
> 
> The goal was to use std::array in the generated shader header. This is
> done in patch 4/4. As a byproduct, I ended up simplifying the generation
> by merging the two scripts into one (2/4) and moving the build logic
> (1/4) and generation script (3/4) to the right location.

I forgot to mention that one of the byproducts is the removal of the
"[SHADER-GEN] $name" messages during build. This is another thing that
pushed me to look at the scripts.

> Laurent Pinchart (4):
>   libcamera: shaders: Move header generation to shaders directory
>   utils: Merge shader header generation scripts
>   utils: Rename and move shader header generation script
>   libcamera: shaders: Replace C array with std::array
> 
>  src/libcamera/meson.build                  | 10 ---
>  src/libcamera/shaders/meson.build          | 10 +++
>  src/libcamera/software_isp/debayer_egl.cpp | 25 +++-----
>  utils/codegen/gen-shader-header.py         | 72 ++++++++++++++++++++++
>  utils/codegen/meson.build                  |  1 +
>  utils/gen-shader-header.py                 | 37 -----------
>  utils/gen-shader-headers.sh                | 54 ----------------
>  utils/meson.build                          |  2 -
>  8 files changed, 91 insertions(+), 120 deletions(-)
>  create mode 100755 utils/codegen/gen-shader-header.py
>  delete mode 100755 utils/gen-shader-header.py
>  delete mode 100755 utils/gen-shader-headers.sh
> 
> 
> base-commit: 7a033dbdd4ca29cca2ef7eb144f6a6f57979b70d