[0/1] Make Raspberry Pi 5 handle buffer offsets
mbox series

Message ID 20260629110240.3656-1-david.plowman@raspberrypi.com
Headers show
Series
  • Make Raspberry Pi 5 handle buffer offsets
Related show

Message

David Plowman June 29, 2026, 10:30 a.m. UTC 
Hi

A short patch which I hope is fairly self-explanatory. Just to note
that it relies on a libpisp release we haven't made yet, but will do
so shortly.

David

David Plowman (1):
  pipeline: rpi: Handle buffers with offsets

 .../pipeline/rpi/common/rpi_stream.h          | 10 ++++++++--
 src/libcamera/pipeline/rpi/pisp/pisp.cpp      | 19 +++++++++++++++++++
 2 files changed, 27 insertions(+), 2 deletions(-)

Comments

Barnabás Pőcze June 30, 2026, 10:58 a.m. UTC | #1 
2026. 06. 29. 12:30 keltezéssel, David Plowman írta:
> Hi
> 
> A short patch which I hope is fairly self-explanatory. Just to note
> that it relies on a libpisp release we haven't made yet, but will do
> so shortly.

When you do that, please include a patch to update subprojects/libpisp.wrap.
If you don't plan on implementing conditional compilation based on the availability,
then please adjust the version requirement for libpisp in src/libcamera/pipeline/rpi/pisp/meson.build.


> 
> David
> 
> David Plowman (1):
>    pipeline: rpi: Handle buffers with offsets
> 
>   .../pipeline/rpi/common/rpi_stream.h          | 10 ++++++++--
>   src/libcamera/pipeline/rpi/pisp/pisp.cpp      | 19 +++++++++++++++++++
>   2 files changed, 27 insertions(+), 2 deletions(-)
>
David Plowman July 1, 2026, 6:52 a.m. UTC | #2 
Hi Barnabas

Ah yes, I've never had to do that before. Will send an update.

Thanks
David

On Tue, 30 Jun 2026 at 11:58, Barnabás Pőcze
<barnabas.pocze@ideasonboard.com> wrote:
>
> 2026. 06. 29. 12:30 keltezéssel, David Plowman írta:
> > Hi
> >
> > A short patch which I hope is fairly self-explanatory. Just to note
> > that it relies on a libpisp release we haven't made yet, but will do
> > so shortly.
>
> When you do that, please include a patch to update subprojects/libpisp.wrap.
> If you don't plan on implementing conditional compilation based on the availability,
> then please adjust the version requirement for libpisp in src/libcamera/pipeline/rpi/pisp/meson.build.
>
>
> >
> > David
> >
> > David Plowman (1):
> >    pipeline: rpi: Handle buffers with offsets
> >
> >   .../pipeline/rpi/common/rpi_stream.h          | 10 ++++++++--
> >   src/libcamera/pipeline/rpi/pisp/pisp.cpp      | 19 +++++++++++++++++++
> >   2 files changed, 27 insertions(+), 2 deletions(-)
> >
>