[v3,0/3] Atomic control lists on Raspberry Pi
mbox series

Message ID 20260428133952.6582-1-david.plowman@raspberrypi.com
Headers show
Series
  • Atomic control lists on Raspberry Pi
Related show

Message

David Plowman April 28, 2026, 1:26 p.m. UTC 
Hi

Version 3 of this set improves the commit message and corrects some of
the documentation in the first of these patches ("Simplify delayed
controls") as Laurent suggested. Otherwise there's just a single typo
fix that Jacopo pointed out.

Thanks!

David

David Plowman (3):
  pipeline: rpi: Simplify delayed controls
  controls: rpi: Add ControlListSequence control
  pipeline: rpi: Make control lists in requests properly atomic

 src/ipa/rpi/common/ipa_base.cpp               | 24 ++++---
 src/libcamera/control_ids_rpi.yaml            |  9 +++
 .../pipeline/rpi/common/delayed_controls.cpp  | 62 +++++++++++--------
 .../pipeline/rpi/common/delayed_controls.h    |  1 -
 .../pipeline/rpi/common/pipeline_base.cpp     | 46 ++++++++++++++
 .../pipeline/rpi/common/pipeline_base.h       |  8 +++
 src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  3 +
 src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  3 +
 8 files changed, 121 insertions(+), 35 deletions(-)

Comments

Naushir Patuck April 28, 2026, 2:11 p.m. UTC | #1 
Hi David,

We seem to have lost my tags, so for this series:

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>

On Tue, 28 Apr 2026 at 14:40, David Plowman
<david.plowman@raspberrypi.com> wrote:
>
> Hi
>
> Version 3 of this set improves the commit message and corrects some of
> the documentation in the first of these patches ("Simplify delayed
> controls") as Laurent suggested. Otherwise there's just a single typo
> fix that Jacopo pointed out.
>
> Thanks!
>
> David
>
> David Plowman (3):
>   pipeline: rpi: Simplify delayed controls
>   controls: rpi: Add ControlListSequence control
>   pipeline: rpi: Make control lists in requests properly atomic
>
>  src/ipa/rpi/common/ipa_base.cpp               | 24 ++++---
>  src/libcamera/control_ids_rpi.yaml            |  9 +++
>  .../pipeline/rpi/common/delayed_controls.cpp  | 62 +++++++++++--------
>  .../pipeline/rpi/common/delayed_controls.h    |  1 -
>  .../pipeline/rpi/common/pipeline_base.cpp     | 46 ++++++++++++++
>  .../pipeline/rpi/common/pipeline_base.h       |  8 +++
>  src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  3 +
>  src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  3 +
>  8 files changed, 121 insertions(+), 35 deletions(-)
>
> --
> 2.47.3
>