[0/2] Add Disco Mode to the rkisp1 pipeline handler
mbox series

Message ID 20260401071650.116344-2-isaac.scott@ideasonboard.com
Headers show
Series
  • Add Disco Mode to the rkisp1 pipeline handler
Related show

Message

Isaac Scott April 1, 2026, 7:16 a.m. UTC
I'm sure I can speak for many users here in saying that libcamera's
current implementation of the pipeline handler of the rkisp1 has a
disappointing lack of "groove". It has made me really struggle to set up
my iMX8MP to record my music videos.

Ultimately, I have had to resort to manually adjusting the output colour
of my monitor, which has proven to be impractical. I've thought about
maybe using a spinning wheel connected to a diesel generator, but alas;
It's just a bit too loud to be able to hear the thumpin' beats from my
meaty subwoofer, so I thought I'd tackle the problem at the source.

This series adds support for 'Disco Mode', with an adjustable Funk
level.

I hope this series helps as many people as possible, as it's certainly
helped me.

Best wishes,

Signed-off-by: Isaac "Funkmaster General" Scott <isaac.scott@ideasonboard.com> 

Isaac Scott (2):
  rkisp1: Add disco mode
  rkisp1: Turn it up to 11

 src/ipa/rkisp1/algorithms/awb.cpp   | 25 +++++++++++++++++++++++++
 src/ipa/rkisp1/ipa_context.h        |  4 ++++
 src/libcamera/control_ids_core.yaml | 17 +++++++++++++++++
 3 files changed, 46 insertions(+)

Comments

Laurent Pinchart April 1, 2026, 7:26 a.m. UTC | #1
Hi Funkmaster General,

On Wed, Apr 01, 2026 at 08:16:37AM +0100, Isaac Scott wrote:
> I'm sure I can speak for many users here in saying that libcamera's
> current implementation of the pipeline handler of the rkisp1 has a
> disappointing lack of "groove". It has made me really struggle to set up
> my iMX8MP to record my music videos.
> 
> Ultimately, I have had to resort to manually adjusting the output colour
> of my monitor, which has proven to be impractical. I've thought about
> maybe using a spinning wheel connected to a diesel generator, but alas;
> It's just a bit too loud to be able to hear the thumpin' beats from my
> meaty subwoofer, so I thought I'd tackle the problem at the source.
> 
> This series adds support for 'Disco Mode', with an adjustable Funk
> level.
> 
> I hope this series helps as many people as possible, as it's certainly
> helped me.

Thank you for the patches, this implements a missing feature in
libcamera that I think many people were waiting for.

As an image is worth a thousand words, I thought a short video that
demonstrates the new disco mode will help the review process:
https://ideasonboard.org/libcamera-disco-mode.mp4

> Best wishes,
> 
> Signed-off-by: Isaac "Funkmaster General" Scott <isaac.scott@ideasonboard.com> 
> 
> Isaac Scott (2):
>   rkisp1: Add disco mode
>   rkisp1: Turn it up to 11
> 
>  src/ipa/rkisp1/algorithms/awb.cpp   | 25 +++++++++++++++++++++++++
>  src/ipa/rkisp1/ipa_context.h        |  4 ++++
>  src/libcamera/control_ids_core.yaml | 17 +++++++++++++++++
>  3 files changed, 46 insertions(+)
Kieran Bingham April 1, 2026, 9:51 a.m. UTC | #2
Hi Isaac,

Quoting Isaac Scott (2026-04-01 08:16:37)
> I'm sure I can speak for many users here in saying that libcamera's
> current implementation of the pipeline handler of the rkisp1 has a
> disappointing lack of "groove". It has made me really struggle to set up
> my iMX8MP to record my music videos.
> 
> Ultimately, I have had to resort to manually adjusting the output colour
> of my monitor, which has proven to be impractical. I've thought about
> maybe using a spinning wheel connected to a diesel generator, but alas;
> It's just a bit too loud to be able to hear the thumpin' beats from my
> meaty subwoofer, so I thought I'd tackle the problem at the source.
> 
> This series adds support for 'Disco Mode', with an adjustable Funk
> level.
> 
> I hope this series helps as many people as possible, as it's certainly
> helped me.
> 
> Best wishes,
> 
> Signed-off-by: Isaac "Funkmaster General" Scott <isaac.scott@ideasonboard.com> 

This is a clear advantage to end users, Especially when Nigel Tufnel
expects his extra push over the cliff, which he has personally asked
for.

I think we should merge it before lunch time even...

Rubber-stamped-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> Isaac Scott (2):
>   rkisp1: Add disco mode
>   rkisp1: Turn it up to 11
> 
>  src/ipa/rkisp1/algorithms/awb.cpp   | 25 +++++++++++++++++++++++++
>  src/ipa/rkisp1/ipa_context.h        |  4 ++++
>  src/libcamera/control_ids_core.yaml | 17 +++++++++++++++++
>  3 files changed, 46 insertions(+)
> 
> -- 
> 2.43.0
>