[v2,0/7] ipa: rkisp1: make Filter tuning-driven and add manual controls
mbox series

Message ID 20260220221636.216353-1-rui.wang@ideasonboard.com
Headers show
Series
  • ipa: rkisp1: make Filter tuning-driven and add manual controls
Related show

Message

Rui Wang Feb. 20, 2026, 10:16 p.m. UTC
Hi all,

This series refactors the rkisp1 Filter algorithm to be fully tuning-driven,
adds rkisp1-specific control definitions for manual filter programming, and
updates imx219 tuning data accordingly.

With this series, denoise/sharpness parameters are parsed from tuning, exposed
through rkisp1 controls, and applied consistently at runtime.

Main changes:
- Parse NoiseReductionModes and Sharpness from tuning data in Filter.
- Apply tuning-derived filter parameters instead of static tables.
- Add rkisp1 vendor control definitions and control range allocation.
- Add draft NoiseReductionModeManual and manual filter control handling.
- Initialize controls from parsed tuning and support manual parameter updates.
- Add filter metadata reporting and config logging helpers.
- Add imx219 Filter tuning section, including manual mode entries.

This improves maintainability, makes sensor tuning explicit in YAML, and
provides a clear path for runtime/manual filter adjustment.

Thanks,
Rui

Rui Wang (7):
  ipa: rkisp1: filter: Parse tuning modes/sharpness from config
  ipa: rkisp1: filter: Apply tuning-based sharpness and filter
  libcamera: Add rkisp1 vendor control definitions
  ipa: rkisp1: filter: Add manual denoise mode and manual filter
    controls
  ipa: rkisp1: filter: Parse tuning at init and active manual-mode
  ipa: rkisp1: filter: add metadata reporting and config logging
  ipa: rkisp1: imx219: Add Filter tuning with manual noise reduction
    mode

 include/libcamera/meson.build         |   1 +
 src/ipa/rkisp1/algorithms/filter.cpp  | 556 ++++++++++++++++++++------
 src/ipa/rkisp1/algorithms/filter.h    |  19 +
 src/ipa/rkisp1/data/imx219.yaml       |  25 ++
 src/libcamera/control_ids_draft.yaml  |   4 +
 src/libcamera/control_ids_rkisp1.yaml | 151 +++++++
 src/libcamera/control_ranges.yaml     |   4 +-
 7 files changed, 640 insertions(+), 120 deletions(-)
 create mode 100644 src/libcamera/control_ids_rkisp1.yaml