[v2,0/4] libcamera: Clean up iterators
mbox series

Message ID 20260212151238.3736234-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: Clean up iterators
Related show

Message

Laurent Pinchart Feb. 12, 2026, 3:12 p.m. UTC 
Hello,

This patch series cleans up usage of iterators to standardize on
range-based loops and structured bindings wherever possible (and
convenient). What started as a single patch is now a series that

- Replaces map iterators and pairs with structured bindings (1/4)
- Replaces iterators for non-associative containers (vector, span, ...)
  with range-based for loops (2/4)
- Rename one occurrence of a variable named 'it' that does not refer to
  an iterator (3/4)
- Standardize on 'const auto' instead of 'auto const'

One thing *not* addressed by this series is replacement of 'auto' with
'const auto' or 'const auto &' where applicable. This could be done on
top by someone with enough motivation :-)

Laurent Pinchart (4):
  libcamera: Replace iterators with structured bindings
  libcamera: Replace iterators with range-based for loops
  libcamera: Use `it` variable name for iterators only
  libcamera: Standardize on 'const auto'

 .../guides/application-developer.rst          |  2 +-
 include/libcamera/base/utils.h                | 10 ++--
 .../libcamera/internal/ipa_data_serializer.h  | 10 ++--
 src/apps/common/options.cpp                   |  6 +--
 src/apps/common/stream_options.cpp            |  4 +-
 src/gstreamer/gstlibcamera-controls.cpp.in    |  7 +--
 src/gstreamer/gstlibcamera-utils.cpp          | 50 ++++++++-----------
 src/ipa/ipu3/ipu3.cpp                         |  8 +--
 src/ipa/mali-c55/mali-c55.cpp                 |  8 +--
 src/ipa/rkisp1/rkisp1.cpp                     |  8 +--
 src/ipa/rpi/common/ipa_base.cpp               |  4 +-
 src/ipa/rpi/controller/controller.cpp         |  6 +--
 src/ipa/rpi/controller/rpi/agc.cpp            |  4 +-
 src/ipa/rpi/controller/rpi/agc_channel.cpp    |  2 +-
 src/ipa/rpi/controller/rpi/lux.cpp            |  2 +-
 src/ipa/rpi/pisp/pisp.cpp                     |  2 +-
 src/ipa/rpi/vc4/vc4.cpp                       |  2 +-
 src/ipa/simple/soft_simple.cpp                |  8 +--
 src/libcamera/camera.cpp                      |  4 +-
 .../converter/converter_v4l2_m2m.cpp          |  8 +--
 src/libcamera/delayed_controls.cpp            |  4 +-
 src/libcamera/media_device.cpp                |  2 +-
 src/libcamera/pipeline/ipu3/cio2.cpp          |  6 +--
 src/libcamera/pipeline/ipu3/ipu3.cpp          | 11 ++--
 src/libcamera/pipeline/mali-c55/mali-c55.cpp  |  2 +-
 .../pipeline/rpi/common/delayed_controls.cpp  |  4 +-
 .../pipeline/rpi/common/pipeline_base.cpp     | 29 ++++++-----
 .../pipeline/rpi/common/rpi_stream.cpp        |  8 +--
 src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  6 +--
 src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  2 +-
 src/libcamera/pipeline/vimc/vimc.cpp          | 10 ++--
 src/libcamera/pipeline/virtual/virtual.cpp    |  2 +-
 src/libcamera/sensor/camera_sensor_legacy.cpp |  4 +-
 src/libcamera/sensor/camera_sensor_raw.cpp    |  4 +-
 src/libcamera/software_isp/software_isp.cpp   |  3 +-
 src/libcamera/stream.cpp                      |  8 +--
 src/libcamera/v4l2_videodevice.cpp            |  8 ++-
 test/media_device/media_device_print_test.cpp | 10 ++--
 test/v4l2_videodevice/buffer_cache.cpp        |  2 +-
 39 files changed, 125 insertions(+), 155 deletions(-)


base-commit: 1dcf9957a47fb54fce4fbae9daec0b587e52562e