[libcamera-devel,0/5] General fixes
mbox series

Message ID 20190117202043.21420-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • General fixes
Related show

Message

Kieran Bingham Jan. 17, 2019, 8:20 p.m. UTC 
Heya,

Here's a few miscellaneous patches I've collected this week while
developing.

The first three patches tackle the Timer class, after I hit an issue
where timers longer than 4.29 seconds fail, due to the internals
wrapping at 32 bits.

The first patch ensures that all member variables are initialised as
this was generating a warning in my IDE static analyser.

Then we add a test which fails, and follow that by a patch to introduce
the fix allowing the test to pass.

Patch 4 fixes up some warnings that our checkstyle.py script complained
about in the log class, and I caught a /really/ trivial spelling error
in event_dispatch_poll.



Kieran Bingham (5):
  test: timer: Initialise all variables
  test: timer: Add a 32 bit wraparound test
  libcamera: timer: Fix 32 bit wrap
  libcamera: log: Fix coding style warnings
  libcamera: event_dispatcher_poll: Fix trivial spelling

 src/libcamera/event_dispatcher_poll.cpp |  2 +-
 src/libcamera/include/log.h             |  6 +++---
 src/libcamera/log.cpp                   |  2 +-
 src/libcamera/timer.cpp                 |  3 ++-
 test/timer.cpp                          | 16 +++++++++++++++-
 5 files changed, 22 insertions(+), 7 deletions(-)