[v3,0/5] libcamera: ipc: ControlLists without valid idmap break IPC
mbox series

Message ID 20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com
Headers show
Series
  • libcamera: ipc: ControlLists without valid idmap break IPC
Related show

Message

Jacopo Mondi Dec. 2, 2025, 2:49 p.m. UTC 
https://gitlab.freedesktop.org/camera/libcamera/-/issues/295

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
Changes in v3:
- Remove "libcamera: request: Remove write-access to controls_"
- Replace it with "libcamera: camera: Ensure a request's controls are
  valid"
- Add two patches to make metadata_ and controls_ class members
- Add review tags

Changes in v2:
- Properly change the access to Request::controls() to const &
- Add patch to make metadata read-only
- Yes, this breaks the API/ABI very much

---
Jacopo Mondi (5):
      libcamera: request: Create control list with Camera info map
      libcamera: request: Move metadata_ to Private
      libcamera: request: Make metadata_ a class instance
      libcamera: request: Make controls_ a class instance
      libcamera: camera: Ensure a request's controls are valid

 include/libcamera/internal/request.h               |  3 ++
 include/libcamera/request.h                        |  7 ++--
 src/libcamera/camera.cpp                           |  6 +++
 src/libcamera/pipeline/imx8-isi/imx8-isi.cpp       |  3 +-
 src/libcamera/pipeline/ipu3/ipu3.cpp               | 16 ++++----
 src/libcamera/pipeline/mali-c55/mali-c55.cpp       |  2 +-
 src/libcamera/pipeline/rkisp1/rkisp1.cpp           | 10 ++---
 .../pipeline/rpi/common/pipeline_base.cpp          | 13 ++++---
 src/libcamera/pipeline/rpi/common/pipeline_base.h  |  2 +-
 src/libcamera/pipeline/simple/simple.cpp           |  8 ++--
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp       |  6 +--
 src/libcamera/pipeline/vimc/vimc.cpp               |  6 +--
 src/libcamera/pipeline/virtual/virtual.cpp         |  4 +-
 src/libcamera/request.cpp                          | 43 +++++++++++-----------
 14 files changed, 69 insertions(+), 60 deletions(-)
---
base-commit: 3a835ff48ccfa6779012dd7d761f8f416dbdef92
change-id: 20251124-cam-control-override-510637bc2b10

Best regards,