[0/2] libcamera: ipc: ControlLists without valid idmap break IPC
mbox series

Message ID 20251124-cam-control-override-v1-0-dfc3a2f3feee@ideasonboard.com
Headers show
Series
  • libcamera: ipc: ControlLists without valid idmap break IPC
Related show

Message

Jacopo Mondi Nov. 24, 2025, 4:43 p.m. UTC
https://gitlab.freedesktop.org/camera/libcamera/-/issues/295

This is first fix for the most visible issue, but I guess the real
fix should be designing an API for the Request class that doesn't
allow applications to overwrite the ControlList associated with a
Request. What do people think ?

Also, an RFC patch for something that seems trivial to me, but I suspect
if it was -that- trivial, it would have been done like this from the
very beginning.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
Jacopo Mondi (2):
      apps: cam: Do not override Request::controls()
      [RFC] libcamera: request: Create control list with Camera info map

 src/apps/cam/camera_session.cpp | 2 +-
 src/libcamera/request.cpp       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: 5a33bc10e9d3bc3a7cb1ead66c7ec0a413083d91
change-id: 20251124-cam-control-override-510637bc2b10

Best regards,