[v1,00/12] Add resampling support for polynomial LSC data
mbox series

Message ID 20251014075252.2876485-1-stefan.klug@ideasonboard.com
Headers show
Series
  • Add resampling support for polynomial LSC data
Related show

Message

Stefan Klug Oct. 14, 2025, 7:52 a.m. UTC 
In [1] support polynomial lens shading tables was implement up to the
same feature level of grid based lens shading tables. However resampling
the LSC table for a given analog crop rectangle was never implemented.

This series partially fixes that by implementing resampling for
polynomial LSC data. Resampling for tabular LSC data is left open for
implementation if need arises.

Patches 1-7 apply some code cleanup that got mentioned on the last
series after it was merged.

Patches 8-10 implement the actual resampling.

Patches 11-12 implement a LensShadingEnable control that is necessary to
assess the effect of LSC in practice. Patch 11 resurrects an old patch
from Jacopo [2]. These last two patches could be stripped off the series
if needed.

Best regards,
Stefan

[1] https://patchwork.libcamera.org/project/libcamera/list/?series=4609&archive=both&state=*
[2] https://patchwork.libcamera.org/project/libcamera/list/?series=3795&archive=both&state=*

Stefan Klug (12):
  ipa: rkisp1: lsc: Drop unused member variable
  ipa: rkisp1: lsc: Drop unused function declaration
  ipa: rkisp1: lsc: Replace assert with ASSERT
  ipa: rkisp1: lsc: Rename res to positions
  ipa: rkisp1: lsc: Rename res to ret
  ipa: rkisp1: lsc: Rename res to samples
  ipa: rksip1: lsc: Move function definitions out of class
  ipa: rkisp1: lsc: Pass sampling positions into samplePolynomial
  ipa: rkisp1: lsc: Pass crop rectangle as parameter
  ipa: rkisp1: lsc: Resample polynomial lens shading tables at configure
    time
  libcamera: control_ids: Introduce LensShadingEnable
  ipa: rkisp1: Add LensShadingEnable control

 src/android/camera_capabilities.cpp  |   4 +-
 src/ipa/rkisp1/algorithms/dpf.cpp    |   2 +-
 src/ipa/rkisp1/algorithms/lsc.cpp    | 454 ++++++++++++++++-----------
 src/ipa/rkisp1/algorithms/lsc.h      |  21 +-
 src/ipa/rkisp1/ipa_context.h         |  12 +-
 src/libcamera/control_ids_core.yaml  |   9 +
 src/libcamera/control_ids_draft.yaml |  14 -
 7 files changed, 315 insertions(+), 201 deletions(-)