[v5,0/3] pipeline: simple: Allow buffer counts from 1 to 32
mbox series

Message ID 20251012142052.90611-1-robert.mader@collabora.com
Headers show
Series
  • pipeline: simple: Allow buffer counts from 1 to 32
Related show

Message

Robert Mader Oct. 12, 2025, 2:20 p.m. UTC 
The last and main commit of this series implements what the title says.
The first commit is a preparation to avoid regressions and the second
commit aligns the internal buffer count for the SW-ISP.

Changes in v5:
1. Reorder commits and add cover-letter.
2. Adopted suggestions for commit messages.
3. Added more tags.

Changes in v4:
1. Limit the number of queued requests to 4

Changes in v3:
1. Adopeted code cleanup suggestion - no change in behavior.
2. Split out change of kNumInternalBuffers.
3. Minor commit message changes.

Changes since v1 with title "pipeline: simple: Allow buffer counts from 1 to 16 for swISP"
1: Cover all cases, not just the swISP one.
2: Increase maximum to 32 to match vb2 core.
3: Change constant naming to better match similar ones.
4: Bump kNumInternalBuffers to 4.

Robert Mader (3):
  pipeline: simple: Initialize maxQueuedRequestsDevice to 4
  pipeline: simple: Increase internal buffers for software ISP to 4
  pipeline: simple: Allow buffer counts from 1 to 32

src/libcamera/pipeline/simple/simple.cpp | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

Comments

Kieran Bingham Oct. 12, 2025, 3:16 p.m. UTC | #1 
Quoting Robert Mader (2025-10-12 15:20:49)
> The last and main commit of this series implements what the title says.
> The first commit is a preparation to avoid regressions and the second
> commit aligns the internal buffer count for the SW-ISP.
> 
> Changes in v5:
> 1. Reorder commits and add cover-letter.
> 2. Adopted suggestions for commit messages.
> 3. Added more tags.

Thanks.

CI is green on this: https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1526042

So I'll merge tomorrow.

--
Kieran

> 
> Changes in v4:
> 1. Limit the number of queued requests to 4
> 
> Changes in v3:
> 1. Adopeted code cleanup suggestion - no change in behavior.
> 2. Split out change of kNumInternalBuffers.
> 3. Minor commit message changes.
> 
> Changes since v1 with title "pipeline: simple: Allow buffer counts from 1 to 16 for swISP"
> 1: Cover all cases, not just the swISP one.
> 2: Increase maximum to 32 to match vb2 core.
> 3: Change constant naming to better match similar ones.
> 4: Bump kNumInternalBuffers to 4.
> 
> Robert Mader (3):
>   pipeline: simple: Initialize maxQueuedRequestsDevice to 4
>   pipeline: simple: Increase internal buffers for software ISP to 4
>   pipeline: simple: Allow buffer counts from 1 to 32
> 
> src/libcamera/pipeline/simple/simple.cpp | 24 ++++++++++++++++++++----
>  1 file changed, 20 insertions(+), 4 deletions(-)
> 
> -- 
> 2.51.0
>