[v4,0/7] Fix stats related problems in software ISP
mbox series

Message ID 20250925192856.77881-1-mzamazal@redhat.com
Headers show
Series
  • Fix stats related problems in software ISP
Related show

Message

Milan Zamazal Sept. 25, 2025, 7:28 p.m. UTC 
Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related
problems discussed there.

Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Tested-by: Robert Mader <robert.mader@collabora.com>

Changes in v4:
- unsigned int underflow in SwStatsCpu::setWindow eliminated.
- Window adjustment clarified in SwStatsCpu::setWindow.

Changes in v3:
- Possible uint64_t underflow eliminated.

Changes in v2:
- An extra semicolon removed.
- A note about the debayering alignment being an implementation
  limitation added.
- A check for division by zero in AGC added.

Milan Zamazal (7):
  libcamera: software_isp: Fix width adjustment in SwStatsCpu::setWindow
  libcamera: software_isp: Clarify SwStatsCpu::setWindow use
  libcamera: software_isp: Pass correct y-coordinate to stats
  libcamera: software_isp: Check processed window size alignment
  libcamera: simple: Avoid incorrect arithmetic in AWB
  ipa: simple: blc: Prevent division by zero in BLC
  ipa: simple: agc: Prevent division by zero in AGC

 src/ipa/simple/algorithms/agc.cpp          |  6 +++++
 src/ipa/simple/algorithms/awb.cpp          | 10 +++++----
 src/ipa/simple/algorithms/blc.cpp          |  5 +++++
 src/libcamera/software_isp/debayer_cpu.cpp | 26 +++++++++++++++++-----
 src/libcamera/software_isp/swstats_cpu.cpp | 21 ++++++++++++++++-
 5 files changed, 57 insertions(+), 11 deletions(-)