| Message ID | 20250917-vd55g1_support-v2-0-101b53b66add@foss.st.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Naush, I think this series is fine - but there's files in src/ipa/rpi. I don't think they're contentious - but could you check if you're fine with these please? -- Regards Kieran Quoting Benjamin Mugnier (2025-09-17 14:42:10) > This series adds the support for vd55g1 in libcamera, both the mono > variant (vd55g1) and the color variant (vd65g4). > > While the vd55g1 is supported kernel side, the vd65g4 support is under > review on the linux-media list, and is yet to be merged. > > This work is pretty close to the vd56g3 support series. > > This series has been developed originally on the Raspberry Pi libcamera > fork and tested on rpi4 and rpi5. Then rebased on mainline and tested > again on rpi4 and rpi5 with the mainline rp1-cfe driver. > > The libipa part has not been tested yet, but changes are rather trivial. > If you see any issues with that, please don't hesitate to remove the > patch from the series. > > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > --- > Changes in v2: > - Update first patch commit message > > --- > Benjamin Mugnier (4): > libcamera: camera_sensor_properties: Add vd55g1 camera sensor > ipa: rpi: Add vd55g1 support for rpi > ipa: rpi: Add vd55g1 tuning files for rpi > libcamera: libipa: Add vd55g1 support for libipa > > src/ipa/libipa/camera_sensor_helper.cpp | 12 + > src/ipa/rpi/cam_helper/cam_helper_vd55g1.cpp | 49 + > src/ipa/rpi/cam_helper/meson.build | 1 + > src/ipa/rpi/pisp/data/meson.build | 2 + > src/ipa/rpi/pisp/data/vd55g1.json | 1209 +++++++++++++++++++++ > src/ipa/rpi/pisp/data/vd55g1_mono.json | 1079 ++++++++++++++++++ > src/ipa/rpi/vc4/data/meson.build | 2 + > src/ipa/rpi/vc4/data/vd55g1.json | 426 ++++++++ > src/ipa/rpi/vc4/data/vd55g1_mono.json | 299 +++++ > src/libcamera/sensor/camera_sensor_properties.cpp | 17 + > 10 files changed, 3096 insertions(+) > --- > base-commit: 6554b6264257af1c3c289d502032b2818d276f65 > change-id: 20250902-vd55g1_support-c7353682586d > > Best regards, > -- > Benjamin Mugnier <benjamin.mugnier@foss.st.com> >
This series adds the support for vd55g1 in libcamera, both the mono variant (vd55g1) and the color variant (vd65g4). While the vd55g1 is supported kernel side, the vd65g4 support is under review on the linux-media list, and is yet to be merged. This work is pretty close to the vd56g3 support series. This series has been developed originally on the Raspberry Pi libcamera fork and tested on rpi4 and rpi5. Then rebased on mainline and tested again on rpi4 and rpi5 with the mainline rp1-cfe driver. The libipa part has not been tested yet, but changes are rather trivial. If you see any issues with that, please don't hesitate to remove the patch from the series. Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> --- Changes in v2: - Update first patch commit message --- Benjamin Mugnier (4): libcamera: camera_sensor_properties: Add vd55g1 camera sensor ipa: rpi: Add vd55g1 support for rpi ipa: rpi: Add vd55g1 tuning files for rpi libcamera: libipa: Add vd55g1 support for libipa src/ipa/libipa/camera_sensor_helper.cpp | 12 + src/ipa/rpi/cam_helper/cam_helper_vd55g1.cpp | 49 + src/ipa/rpi/cam_helper/meson.build | 1 + src/ipa/rpi/pisp/data/meson.build | 2 + src/ipa/rpi/pisp/data/vd55g1.json | 1209 +++++++++++++++++++++ src/ipa/rpi/pisp/data/vd55g1_mono.json | 1079 ++++++++++++++++++ src/ipa/rpi/vc4/data/meson.build | 2 + src/ipa/rpi/vc4/data/vd55g1.json | 426 ++++++++ src/ipa/rpi/vc4/data/vd55g1_mono.json | 299 +++++ src/libcamera/sensor/camera_sensor_properties.cpp | 17 + 10 files changed, 3096 insertions(+) --- base-commit: 6554b6264257af1c3c289d502032b2818d276f65 change-id: 20250902-vd55g1_support-c7353682586d Best regards,