[0/4] ipa: libipa: Introduce V4L2Params
mbox series

Message ID 20250829-v4l2-params-v1-0-340773fb69ff@ideasonboard.com
Headers show
Series
  • ipa: libipa: Introduce V4L2Params
Related show

Message

Jacopo Mondi Aug. 29, 2025, 11:53 a.m. UTC
With the introduction of v4l2-extensible-params in the Linux kernel
currently in progress:
https://lore.kernel.org/all/20250820-extensible-parameters-validation-v4-0-30fe5a99cb1f@ideasonboard.com/

the MaliC55 ISP driver at version in v11 has been ported to use a
parameters format compatible with the one defined by v4l2 extensible
parameters:
https://lore.kernel.org/all/20250714-c55-v11-0-bc20e460e42a@ideasonboard.com/

This series
1) Imports v4l2-extensible-params in libcamera
2) Update the Mali C55 header and IPA to compile with v11 of the patch
   series that introduces MaliC55 support in Linux
3) Introduces V4L2Params by generalizing RkISP1Params
4) Ports the Mali C55 IPA to use the newly introduced V4L2Params

Tested on rkisp1 and rzv2h

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
Jacopo Mondi (4):
      include: linux: Add v4l2-extensible-params.h
      ipa: Update Mali C55 header file and adjust IPA
      ipa: libipa: Introduce V4L2Params
      ipa: mali-c55: Introduce MaliC55Params

 include/linux/mali-c55-config.h              | 162 +++--------------
 include/linux/media/v4l2-extensible-params.h | 144 +++++++++++++++
 src/ipa/libipa/meson.build                   |   2 +
 src/ipa/libipa/v4l2_params.cpp               | 252 +++++++++++++++++++++++++++
 src/ipa/libipa/v4l2_params.h                 | 135 ++++++++++++++
 src/ipa/mali-c55/algorithms/agc.cpp          |  87 ++++-----
 src/ipa/mali-c55/algorithms/agc.h            |  14 +-
 src/ipa/mali-c55/algorithms/algorithm.h      |   2 +-
 src/ipa/mali-c55/algorithms/awb.cpp          |  64 +++----
 src/ipa/mali-c55/algorithms/awb.h            |  10 +-
 src/ipa/mali-c55/algorithms/blc.cpp          |  20 +--
 src/ipa/mali-c55/algorithms/blc.h            |   3 +-
 src/ipa/mali-c55/algorithms/lsc.cpp          |  58 +++---
 src/ipa/mali-c55/algorithms/lsc.h            |   8 +-
 src/ipa/mali-c55/mali-c55.cpp                |  19 +-
 src/ipa/mali-c55/module.h                    |   3 +-
 src/ipa/mali-c55/params.h                    |  89 ++++++++++
 src/ipa/rkisp1/params.cpp                    |  93 +---------
 src/ipa/rkisp1/params.h                      | 108 +++++-------
 19 files changed, 810 insertions(+), 463 deletions(-)
---
base-commit: d54e5537ca0909339bb6950f3a565c9077406a3c
change-id: 20250829-v4l2-params-d42aa599e78a

Best regards,

Comments

Antoine Bouyer Sept. 8, 2025, 2:38 p.m. UTC | #1
On 29/08/2025 13:53, Jacopo Mondi wrote:
> With the introduction of v4l2-extensible-params in the Linux kernel
> currently in progress:
> https://lore.kernel.org/all/20250820-extensible-parameters-validation-v4-0-30fe5a99cb1f@ideasonboard.com/
> 
> the MaliC55 ISP driver at version in v11 has been ported to use a
> parameters format compatible with the one defined by v4l2 extensible
> parameters:
> https://lore.kernel.org/all/20250714-c55-v11-0-bc20e460e42a@ideasonboard.com/
> 
> This series
> 1) Imports v4l2-extensible-params in libcamera
> 2) Update the Mali C55 header and IPA to compile with v11 of the patch
>     series that introduces MaliC55 support in Linux
> 3) Introduces V4L2Params by generalizing RkISP1Params
> 4) Ports the Mali C55 IPA to use the newly introduced V4L2Params
> 
> Tested on rkisp1 and rzv2h
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

I tested the same on NXP neo ISP locally, which also uses extended params.

For the series
Tested-By: Antoine Bouyer <antoine.bouyer@nxp.com>

Best regards
Antoine

> ---
> Jacopo Mondi (4):
>        include: linux: Add v4l2-extensible-params.h
>        ipa: Update Mali C55 header file and adjust IPA
>        ipa: libipa: Introduce V4L2Params
>        ipa: mali-c55: Introduce MaliC55Params
> 
>   include/linux/mali-c55-config.h              | 162 +++--------------
>   include/linux/media/v4l2-extensible-params.h | 144 +++++++++++++++
>   src/ipa/libipa/meson.build                   |   2 +
>   src/ipa/libipa/v4l2_params.cpp               | 252 +++++++++++++++++++++++++++
>   src/ipa/libipa/v4l2_params.h                 | 135 ++++++++++++++
>   src/ipa/mali-c55/algorithms/agc.cpp          |  87 ++++-----
>   src/ipa/mali-c55/algorithms/agc.h            |  14 +-
>   src/ipa/mali-c55/algorithms/algorithm.h      |   2 +-
>   src/ipa/mali-c55/algorithms/awb.cpp          |  64 +++----
>   src/ipa/mali-c55/algorithms/awb.h            |  10 +-
>   src/ipa/mali-c55/algorithms/blc.cpp          |  20 +--
>   src/ipa/mali-c55/algorithms/blc.h            |   3 +-
>   src/ipa/mali-c55/algorithms/lsc.cpp          |  58 +++---
>   src/ipa/mali-c55/algorithms/lsc.h            |   8 +-
>   src/ipa/mali-c55/mali-c55.cpp                |  19 +-
>   src/ipa/mali-c55/module.h                    |   3 +-
>   src/ipa/mali-c55/params.h                    |  89 ++++++++++
>   src/ipa/rkisp1/params.cpp                    |  93 +---------
>   src/ipa/rkisp1/params.h                      | 108 +++++-------
>   19 files changed, 810 insertions(+), 463 deletions(-)
> ---
> base-commit: d54e5537ca0909339bb6950f3a565c9077406a3c
> change-id: 20250829-v4l2-params-d42aa599e78a
> 
> Best regards,
> --
> Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>