[RFC,0/4] libipa: agc_mean_luminance: Use composition instead of
mbox series

Message ID 20250818082909.2001635-1-stefan.klug@ideasonboard.com
Headers show
Series
  • libipa: agc_mean_luminance: Use composition instead of
Related show

Message

Stefan Klug Aug. 18, 2025, 8:28 a.m. UTC 
Hi all,

I found myself regularly getting confused by the control flow in the
rkisp1 AGC algorithm. I then realized that it is due to Agc being
derived from AgcMeanLuminance even though there is very little automatic
functionality coming from AgcMeanLuminance. So I gave it a try to
remove the need to derive from AgcMeanLuminance and this is the result.

I believe it makes things easier to understand. But maybe that is just me.
What do you think?

Best regards,
Stefan

Stefan Klug (4):
  libipa: agc_mean_luminance: pass estimateLuminance() as parameter
  ipa: rkisp1: agc: Do not derive from AgcMeanLuminance
  ipa: ipu3: agc: Do not derive from AgcMeanLuminance
  ipa: mali-c55: agc: Do not derive from AgcMeanLuminance

 src/ipa/ipu3/algorithms/agc.cpp       | 22 ++++++-----
 src/ipa/ipu3/algorithms/agc.h         |  6 ++-
 src/ipa/libipa/agc_mean_luminance.cpp | 57 ++++++++++++++-------------
 src/ipa/libipa/agc_mean_luminance.h   |  9 +++--
 src/ipa/mali-c55/algorithms/agc.cpp   | 22 ++++++-----
 src/ipa/mali-c55/algorithms/agc.h     |  5 ++-
 src/ipa/rkisp1/algorithms/agc.cpp     | 43 +++++++++++---------
 src/ipa/rkisp1/algorithms/agc.h       |  8 ++--
 8 files changed, 94 insertions(+), 78 deletions(-)