[v3,0/2] pipeline: imx8-isi: Add multicamera support
mbox series

Message ID 20250630150128.2435445-1-antoine.bouyer@nxp.com
Headers show
Series
  • pipeline: imx8-isi: Add multicamera support
Related show

Message

Antoine Bouyer June 30, 2025, 3:01 p.m. UTC 
This is third patchset for adding support of multicamera into imx8-isi
pipeline handler. Compared to v2, it adds const prefix to 'xbarFirstSource'
and 'maxStreams' variables, to avoid confusion as they both are constant
values.

Missing R-b tag also added as requested. Sorry for not having integrated it
earlier in V2.

Antoine Bouyer (2):
  pipeline: imx8-isi: Add constexpr for maximum pipeline and resize if
    needed
  pipeline: imx8-isi: Add multicamera support

 src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 119 ++++++++++++-------
 1 file changed, 79 insertions(+), 40 deletions(-)

Comments

Laurent Pinchart June 30, 2025, 5:52 p.m. UTC | #1 
Hi Antoine,

On Mon, Jun 30, 2025 at 05:01:26PM +0200, Antoine Bouyer wrote:
> This is third patchset for adding support of multicamera into imx8-isi
> pipeline handler. Compared to v2, it adds const prefix to 'xbarFirstSource'
> and 'maxStreams' variables, to avoid confusion as they both are constant
> values.
> 
> Missing R-b tag also added as requested. Sorry for not having integrated it
> earlier in V2.

I'm afraid the series doesn't apply on top of the latest master branch
:-( It conflicts with

commit d3f3b95b64d2239adca7e0c6e9eb35db690ca98d (fdo/patchwork/5207)
Author: Antoine Bouyer <antoine.bouyer@nxp.com>
Date:   Fri Jun 6 09:34:59 2025 +0200

    pipeline: imx8-isi: Dynamically compute crossbar subdevice's first source.

Could you please rebase ?

> Antoine Bouyer (2):
>   pipeline: imx8-isi: Add constexpr for maximum pipeline and resize if
>     needed
>   pipeline: imx8-isi: Add multicamera support
> 
>  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 119 ++++++++++++-------
>  1 file changed, 79 insertions(+), 40 deletions(-)