[0/1] Fix AeEnable when camera starts
mbox series

Message ID 20250521125327.6378-1-david.plowman@raspberrypi.com
Headers show
Series
  • Fix AeEnable when camera starts
Related show

Message

David Plowman May 21, 2025, 12:53 p.m. UTC 
Hi everyone

Not a big patch, but also not a lovely one, so folks might have some
opinions on how it should look.

The problem is that we patch up control lists for the "AeEnable"
control when we queue a request, but not when the camera starts -
leading to different behaviour depending on when you send your
controls.

This patch fixes that, by factoring the patch-up code into a separate
method, and then, in Camera::start(), we copy the control list because
the one passed in is const.

Anyway, opinions on how this should look gratefully received, and I'll
do another version once things seem clear.

Thanks!
David

David Plowman (1):
  libcamera: camera: Fix up the AeEnable control during Camera::start()

 include/libcamera/camera.h |  2 ++
 src/libcamera/camera.cpp   | 57 +++++++++++++++++++++++++-------------
 2 files changed, 40 insertions(+), 19 deletions(-)