[v3,0/1] libcamera: process: Pass stderr and reserve stdin and stdout fds
mbox series

Message ID 20250519122352.1675360-1-julien.vuillaumier@nxp.com
Headers show
Series
  • libcamera: process: Pass stderr and reserve stdin and stdout fds
Related show

Message

Julien Vuillaumier May 19, 2025, 12:23 p.m. UTC 
Hello,

This is the v3 of this patch aimed at letting a child process to log
onto parent's stderr, and making sure that its stdin/stdout/stderr
fds are not free to reuse.

It addresses the review comments from Barnabás.

v3: 
- Give the option to inherit from any standard file descriptor from
  the parent 
- Fix a possible self duplication of descriptors
- Fix the null device descriptor that unnecessarily remains opens

v2:
- Pass only parent's stderr to the child process for logging purpose
- Reallocate child's stdin/stdout file descriptors to /dev/null (daemon style) so
  that they are not recycled for other usage

Thanks,
Julien

Julien Vuillaumier (1):
  libcamera: process: Pass stderr and reserve stdin and stdout fds

 src/libcamera/process.cpp | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)