[v2,0/3] libcamera: controls: String controls as `std::string_view`
mbox series

Message ID 20250501095818.3996419-1-barnabas.pocze@ideasonboard.com
Headers show
Series
  • libcamera: controls: String controls as `std::string_view`
Related show

Message

Barnabás Pőcze May 1, 2025, 9:58 a.m. UTC 
This change brings string controls in line with other controls in that
no non-trivial copies will be made when a value is retrieved from a
`ControlValue` instance.

https://bugs.libcamera.org/show_bug.cgi?id=256

changes in v2:
  * fix rebuilding when controls.py is modified

v1: https://patchwork.libcamera.org/cover/23204/

Barnabás Pőcze (3):
  apps: cam: capture_script: Disallow arrays of strings
  utils: codegen: Make users depend on `controls.py` in meson
  libcamera: controls: Expose string controls as `std::string_view`

 include/libcamera/control_ids.h.in  |  1 +
 include/libcamera/controls.h        | 15 ++++++++-------
 include/libcamera/meson.build       |  1 +
 src/apps/cam/capture_script.cpp     |  6 +-----
 src/apps/cam/main.cpp               |  2 +-
 src/apps/common/dng_writer.cpp      |  2 +-
 src/apps/qcam/cam_select_dialog.cpp |  6 +++---
 src/gstreamer/meson.build           |  1 +
 src/libcamera/meson.build           |  1 +
 src/py/libcamera/meson.build        |  2 ++
 src/py/libcamera/py_helpers.cpp     |  4 ++--
 test/controls/control_value.cpp     |  4 ++--
 utils/codegen/controls.py           |  2 +-
 utils/codegen/meson.build           |  2 ++
 14 files changed, 27 insertions(+), 22 deletions(-)

--
2.49.0