[v9,00/12] AEGC controls
mbox series

Message ID 20250120204515.24096-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • AEGC controls
Related show

Message

Laurent Pinchart Jan. 20, 2025, 8:44 p.m. UTC
Hello,

I was about to merge Paul's v8 of this series when I noticed it failed
to compile in v8.1 of 05/12. So close, yet so far.

I've fixed the issue, and I'm sending a v9 to avoid another time
zone-induced large round-trip. The only change compared to v8 is in
05/12. Naush, David, could you please have a look ?

Jacopo Mondi (4):
  libcamera: uvcvideo: Register ExposureTimeMode control
  test: ipa_data_serialization: Use DebugMetadataEnable
  ipa: raspberry: Port to the new AEGC controls
  controls: Remove AeLocked

Paul Elder (8):
  controls: Introduce AEGC-related controls
  Documentation: design: ae: Document the design for AE controls
  ipa: rkisp1: Port to the new AEGC controls
  gstreamer: Generate the new AEGC controls
  controls: Redefine AeEnable
  libcamera: camera: Pre-process AeEnable control
  ipa: rkisp1: agc: Report new AeEnable control as available
  ipa: raspberry: Report new AeEnable control as available

 Documentation/design/ae.rst                   | 331 ++++++++++++++++++
 Documentation/index.rst                       |   4 +-
 Documentation/meson.build                     |   1 +
 src/ipa/rkisp1/algorithms/agc.cpp             | 133 +++++--
 src/ipa/rkisp1/ipa_context.cpp                |  24 +-
 src/ipa/rkisp1/ipa_context.h                  |   8 +-
 src/ipa/rpi/common/ipa_base.cpp               | 104 ++++--
 src/ipa/rpi/controller/agc_algorithm.h        |   8 +-
 src/ipa/rpi/controller/rpi/agc.cpp            |  52 ++-
 src/ipa/rpi/controller/rpi/agc.h              |   8 +-
 src/ipa/rpi/controller/rpi/agc_channel.cpp    |  24 +-
 src/ipa/rpi/controller/rpi/agc_channel.h      |   8 +-
 src/libcamera/camera.cpp                      |  20 ++
 src/libcamera/control_ids_core.yaml           | 279 +++++++++++++--
 src/libcamera/control_ids_draft.yaml          |  30 --
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  53 ++-
 .../ipa_data_serializer_test.cpp              |   2 +-
 utils/codegen/gen-gst-controls.py             |   5 +-
 18 files changed, 960 insertions(+), 134 deletions(-)
 create mode 100644 Documentation/design/ae.rst


base-commit: b01918978c8281d344d5408b3a13aab9e5af4b5d
--
Regards,

Laurent Pinchart

Comments

Naushir Patuck Jan. 21, 2025, 8:59 a.m. UTC | #1
Hi Laurent,

On Mon, 20 Jan 2025 at 20:45, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hello,
>
> I was about to merge Paul's v8 of this series when I noticed it failed
> to compile in v8.1 of 05/12. So close, yet so far.
>
> I've fixed the issue, and I'm sending a v9 to avoid another time
> zone-induced large round-trip. The only change compared to v8 is in
> 05/12. Naush, David, could you please have a look ?

The patch looks fine to me!

Naush


>
> Jacopo Mondi (4):
>   libcamera: uvcvideo: Register ExposureTimeMode control
>   test: ipa_data_serialization: Use DebugMetadataEnable
>   ipa: raspberry: Port to the new AEGC controls
>   controls: Remove AeLocked
>
> Paul Elder (8):
>   controls: Introduce AEGC-related controls
>   Documentation: design: ae: Document the design for AE controls
>   ipa: rkisp1: Port to the new AEGC controls
>   gstreamer: Generate the new AEGC controls
>   controls: Redefine AeEnable
>   libcamera: camera: Pre-process AeEnable control
>   ipa: rkisp1: agc: Report new AeEnable control as available
>   ipa: raspberry: Report new AeEnable control as available
>
>  Documentation/design/ae.rst                   | 331 ++++++++++++++++++
>  Documentation/index.rst                       |   4 +-
>  Documentation/meson.build                     |   1 +
>  src/ipa/rkisp1/algorithms/agc.cpp             | 133 +++++--
>  src/ipa/rkisp1/ipa_context.cpp                |  24 +-
>  src/ipa/rkisp1/ipa_context.h                  |   8 +-
>  src/ipa/rpi/common/ipa_base.cpp               | 104 ++++--
>  src/ipa/rpi/controller/agc_algorithm.h        |   8 +-
>  src/ipa/rpi/controller/rpi/agc.cpp            |  52 ++-
>  src/ipa/rpi/controller/rpi/agc.h              |   8 +-
>  src/ipa/rpi/controller/rpi/agc_channel.cpp    |  24 +-
>  src/ipa/rpi/controller/rpi/agc_channel.h      |   8 +-
>  src/libcamera/camera.cpp                      |  20 ++
>  src/libcamera/control_ids_core.yaml           | 279 +++++++++++++--
>  src/libcamera/control_ids_draft.yaml          |  30 --
>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  53 ++-
>  .../ipa_data_serializer_test.cpp              |   2 +-
>  utils/codegen/gen-gst-controls.py             |   5 +-
>  18 files changed, 960 insertions(+), 134 deletions(-)
>  create mode 100644 Documentation/design/ae.rst
>
>
> base-commit: b01918978c8281d344d5408b3a13aab9e5af4b5d
> --
> Regards,
>
> Laurent Pinchart
>