[v2,0/1] libcamera: process: Pass stderr and reserve stdin and stdout fds
mbox series

Message ID 20241218182754.2414920-1-julien.vuillaumier@nxp.com
Headers show
Series
  • libcamera: process: Pass stderr and reserve stdin and stdout fds
Related show

Message

Julien Vuillaumier Dec. 18, 2024, 6:27 p.m. UTC 
Hi,

This is the v2 for the patch:
"libcamera: ipc_unixsocket: Share stdin and stdout with IPA proxy"
https://patchwork.libcamera.org/patch/21815/
Patch has been renamed, apologies for the confusion if any.

It is a safer implementation that hopefully addresses the concerns from Laurent's
review comments about possible standard streams remap by the application.

v1->v2:
- Pass only parent's stderr to the child process for logging purpose
- Reallocate child's stdin/stdout file descriptors to /dev/null (daemon style) so
  that they are not recycled for other usage

Kieran, Paul, as the approach is a bit different, I did not report your
Reviewed-by in the commit message - hope that is fine with you.

Thanks,
Julien

Julien Vuillaumier (1):
  libcamera: process: Pass stderr and reserve stdin and stdout fds

 src/libcamera/process.cpp | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)