[v5,0/8] AEGC controls
mbox series

Message ID 20241216043954.3506855-1-paul.elder@ideasonboard.com
Headers show
Series
  • AEGC controls
Related show

Message

Paul Elder Dec. 16, 2024, 4:39 a.m. UTC 
This patch series introduces a new set of AEGC controls that allow:
- flicker avoidance when switching from auto to manual
- shutter priority / gain priority

To achieve this, we remove the existing AeEnable control and add two
separate controls that control enabling/disabling auto-exposure and
auto-gain. The definition of AeState is also made more concrete. The
first two patches add the new controls, as well as documentation and
design rationale.

The rest of the patches naturally update the existing users of AeEnable,
before finally removing the control altogether.

v4 mainly improves documentation and implements the proper behavior when
transitioning between auto and manual modes for the rkisp1.

v5 is mostly minor wording changes, plus a fix to the rkisp1 aegc
implementation to support mixed manual-auto ae modes (aka "shutter
priority" / "gain priority").

Thanks,

Paul

Jacopo Mondi (4):
  libcamera: uvcvideo: Register ExposureTimeMode control
  test: ipa_data_serialization: Use DebugMetadataEnable
  ipa: raspberry: Port to the new AEGC controls
  controls: Remove AeEnable and AeLocked

Paul Elder (4):
  controls: Introduce AEGC-related controls
  Documentation: design: ae: Document the design for AE controls
  ipa: rkisp1: Port to the new AEGC controls
  gstreamer: Generate the new AEGC controls

 Documentation/design/ae.rst                   | 320 ++++++++++++++++++
 Documentation/index.rst                       |   4 +-
 Documentation/meson.build                     |   1 +
 src/ipa/rkisp1/algorithms/agc.cpp             | 122 +++++--
 src/ipa/rkisp1/ipa_context.cpp                |  24 +-
 src/ipa/rkisp1/ipa_context.h                  |   8 +-
 src/ipa/rpi/common/ipa_base.cpp               |  74 +++-
 src/ipa/rpi/controller/agc_algorithm.h        |   8 +-
 src/ipa/rpi/controller/rpi/agc.cpp            |  52 ++-
 src/ipa/rpi/controller/rpi/agc.h              |   8 +-
 src/ipa/rpi/controller/rpi/agc_channel.cpp    |  24 +-
 src/ipa/rpi/controller/rpi/agc_channel.h      |   8 +-
 src/libcamera/control_ids_core.yaml           | 268 +++++++++++++--
 src/libcamera/control_ids_draft.yaml          |  29 --
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  53 ++-
 .../ipa_data_serializer_test.cpp              |   2 +-
 utils/codegen/gen-gst-controls.py             |   5 +-
 17 files changed, 890 insertions(+), 120 deletions(-)
 create mode 100644 Documentation/design/ae.rst