| Message ID | 20241129123032.2957763-1-chenghaoyang@chromium.org |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Quoting Harvey Yang (2024-11-29 12:27:48) > Hi folks, > > This patch adds camera sensor properties for sensors on mtkisp7. It's > required to produce correct color bars test pattern instead of random > pattern. > > Tested on mtkisp7 branch with ChromeOS tast test `camera.HAL3Frame`. > > This patch passed gitlab pipeline: > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1319966 Getting this one through the merge CI has been problematic because of failed tests related to ThreadAffinity. These patches are not expected to be related to the failures I saw on ThreadAffinity, and on the third attempt I now have a successful [0] pipeline, so I'll merge these now. [0] https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1320174 -- Kieran > > The source file includes quite some legacy code that has linter > warnings. This patch follows the same legacy format, so there are some > lint warnings as well. > > v7: > - Updated commits' author. > > v6: > - Added controls' delays. > > v5: > - Fixed the conversion from RAW10 to RAW16 for black levels. > > v4: > - Added black level values. > > v3: > - Updated commit messages. > - Added proper linear conversion rules for the two sensors. > > v2: > - Removed hi1339 that was not upstreamed and deprecated. > - Added CameraSensorHelper implementations, while might not end up > using. > - Split into two patches for two sensors. > > BR, > Harvey > > Harvey Yang (2): > libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor > properties > libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor > properties > > src/ipa/libipa/camera_sensor_helper.cpp | 26 +++++++++++++++++++ > .../sensor/camera_sensor_properties.cpp | 26 +++++++++++++++++++ > 2 files changed, 52 insertions(+) > > -- > 2.47.0.338.g60cca15819-goog >
Thank you Kieran! On Sat, Nov 30, 2024 at 5:17 AM Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > > Quoting Harvey Yang (2024-11-29 12:27:48) > > Hi folks, > > > > This patch adds camera sensor properties for sensors on mtkisp7. It's > > required to produce correct color bars test pattern instead of random > > pattern. > > > > Tested on mtkisp7 branch with ChromeOS tast test `camera.HAL3Frame`. > > > > This patch passed gitlab pipeline: > > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1319966 > > Getting this one through the merge CI has been problematic because of > failed tests related to ThreadAffinity. > > These patches are not expected to be related to the failures I saw on > ThreadAffinity, and on the third attempt I now have a successful [0] > pipeline, so I'll merge these now. > > [0] https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1320174 > > -- > Kieran > > > > > The source file includes quite some legacy code that has linter > > warnings. This patch follows the same legacy format, so there are some > > lint warnings as well. > > > > v7: > > - Updated commits' author. > > > > v6: > > - Added controls' delays. > > > > v5: > > - Fixed the conversion from RAW10 to RAW16 for black levels. > > > > v4: > > - Added black level values. > > > > v3: > > - Updated commit messages. > > - Added proper linear conversion rules for the two sensors. > > > > v2: > > - Removed hi1339 that was not upstreamed and deprecated. > > - Added CameraSensorHelper implementations, while might not end up > > using. > > - Split into two patches for two sensors. > > > > BR, > > Harvey > > > > Harvey Yang (2): > > libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor > > properties > > libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor > > properties > > > > src/ipa/libipa/camera_sensor_helper.cpp | 26 +++++++++++++++++++ > > .../sensor/camera_sensor_properties.cpp | 26 +++++++++++++++++++ > > 2 files changed, 52 insertions(+) > > > > -- > > 2.47.0.338.g60cca15819-goog > >
Hi folks, This patch adds camera sensor properties for sensors on mtkisp7. It's required to produce correct color bars test pattern instead of random pattern. Tested on mtkisp7 branch with ChromeOS tast test `camera.HAL3Frame`. This patch passed gitlab pipeline: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1319966 The source file includes quite some legacy code that has linter warnings. This patch follows the same legacy format, so there are some lint warnings as well. v7: - Updated commits' author. v6: - Added controls' delays. v5: - Fixed the conversion from RAW10 to RAW16 for black levels. v4: - Added black level values. v3: - Updated commit messages. - Added proper linear conversion rules for the two sensors. v2: - Removed hi1339 that was not upstreamed and deprecated. - Added CameraSensorHelper implementations, while might not end up using. - Split into two patches for two sensors. BR, Harvey Harvey Yang (2): libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor properties libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor properties src/ipa/libipa/camera_sensor_helper.cpp | 26 +++++++++++++++++++ .../sensor/camera_sensor_properties.cpp | 26 +++++++++++++++++++ 2 files changed, 52 insertions(+)