[0/2] Use Sensor Delays from CameraSensorProperties in RPi
mbox series

Message ID 20241127133233.247977-1-dan.scally@ideasonboard.com
Headers show
Series
  • Use Sensor Delays from CameraSensorProperties in RPi
Related show

Message

Dan Scally Nov. 27, 2024, 1:32 p.m. UTC 
Hello all

This set follows on from the recent move to add control delay values to the
CameraSensorProperties data by removing the independent implementation found in
the Raspberry Pi IPA's CameraSensorHelpers. The IPA had helpers for two sensors,
the OV7251 and OV9281, which did not have any CameraSensorProperties defined so
a patch is included to add those.

Thanks
Dan

Daniel Scally (2):
  libcamera: camera_sensor_properties: Add ov7251 and ov9281
  libcamera: rpi: Draw sensor delays from CameraSensorProperties

 include/libcamera/ipa/raspberrypi.mojom       |  4 ----
 src/ipa/rpi/cam_helper/cam_helper.cpp         | 13 ------------
 src/ipa/rpi/cam_helper/cam_helper.h           |  7 -------
 src/ipa/rpi/cam_helper/cam_helper_imx283.cpp  | 12 -----------
 src/ipa/rpi/cam_helper/cam_helper_imx290.cpp  | 11 ----------
 src/ipa/rpi/cam_helper/cam_helper_imx296.cpp  | 11 ----------
 src/ipa/rpi/cam_helper/cam_helper_imx477.cpp  | 11 ----------
 src/ipa/rpi/cam_helper/cam_helper_imx519.cpp  | 11 ----------
 src/ipa/rpi/cam_helper/cam_helper_imx708.cpp  | 11 ----------
 src/ipa/rpi/cam_helper/cam_helper_ov5647.cpp  | 15 --------------
 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp | 12 -----------
 src/ipa/rpi/cam_helper/cam_helper_ov7251.cpp  | 12 -----------
 src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp  | 12 -----------
 src/ipa/rpi/common/ipa_base.cpp               | 14 ++-----------
 .../pipeline/rpi/common/pipeline_base.cpp     |  9 +++++----
 .../sensor/camera_sensor_properties.cpp       | 20 +++++++++++++++++++
 16 files changed, 27 insertions(+), 158 deletions(-)

Comments

Naushir Patuck Dec. 2, 2024, 8:41 a.m. UTC | #1 
Hi Dan,

On Wed, 27 Nov 2024 at 13:32, Daniel Scally <dan.scally@ideasonboard.com> wrote:
>
> Hello all
>
> This set follows on from the recent move to add control delay values to the
> CameraSensorProperties data by removing the independent implementation found in
> the Raspberry Pi IPA's CameraSensorHelpers. The IPA had helpers for two sensors,
> the OV7251 and OV9281, which did not have any CameraSensorProperties defined so
> a patch is included to add those.
>
> Thanks
> Dan

Thanks for tidying this up!  For both patches:

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>


>
> Daniel Scally (2):
>   libcamera: camera_sensor_properties: Add ov7251 and ov9281
>   libcamera: rpi: Draw sensor delays from CameraSensorProperties
>
>  include/libcamera/ipa/raspberrypi.mojom       |  4 ----
>  src/ipa/rpi/cam_helper/cam_helper.cpp         | 13 ------------
>  src/ipa/rpi/cam_helper/cam_helper.h           |  7 -------
>  src/ipa/rpi/cam_helper/cam_helper_imx283.cpp  | 12 -----------
>  src/ipa/rpi/cam_helper/cam_helper_imx290.cpp  | 11 ----------
>  src/ipa/rpi/cam_helper/cam_helper_imx296.cpp  | 11 ----------
>  src/ipa/rpi/cam_helper/cam_helper_imx477.cpp  | 11 ----------
>  src/ipa/rpi/cam_helper/cam_helper_imx519.cpp  | 11 ----------
>  src/ipa/rpi/cam_helper/cam_helper_imx708.cpp  | 11 ----------
>  src/ipa/rpi/cam_helper/cam_helper_ov5647.cpp  | 15 --------------
>  src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp | 12 -----------
>  src/ipa/rpi/cam_helper/cam_helper_ov7251.cpp  | 12 -----------
>  src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp  | 12 -----------
>  src/ipa/rpi/common/ipa_base.cpp               | 14 ++-----------
>  .../pipeline/rpi/common/pipeline_base.cpp     |  9 +++++----
>  .../sensor/camera_sensor_properties.cpp       | 20 +++++++++++++++++++
>  16 files changed, 27 insertions(+), 158 deletions(-)
>
> --
> 2.34.1
>