[0/4] Move Matrix class from libipa to libcamera
mbox series

Message ID 20241118150528.1856797-1-stefan.klug@ideasonboard.com
Headers show
Series
  • Move Matrix class from libipa to libcamera
Related show

Message

Stefan Klug Nov. 18, 2024, 3:05 p.m. UTC 
Hi all,

My upcoming dewarper series implements parametric lens dewarping inside
the rkisp1 pipeline. That code makes use of the Matrix class but lives
outside of the IPA. I suspect there will be more cases, where a matrix
is of good use inside libcamera.

This series movies the Matrix into libacmera/internal. As that gets
linked to the IPAs anyways, there are no negative effects for the IPAs.

This was tested on an imx8mp, but only compile tested for the
RaspberryPi.

Regards,
Stefan

Stefan Klug (4):
  libcamera: Copy matrix class from libipa to libcamera
  libcamera: Enable and use matrix implementation from
    libcamera/internal
  libcamera: matrix: Use Span instead of vector for construction
  libipa: Remove Matrix class from libipa

 .../libcamera/internal}/matrix.h              | 23 ++++----
 include/libcamera/internal/meson.build        |  1 +
 src/ipa/libipa/meson.build                    |  2 -
 src/ipa/libipa/vector.h                       |  3 +-
 src/ipa/rkisp1/algorithms/ccm.h               |  3 +-
 src/ipa/rkisp1/ipa_context.h                  |  2 +-
 src/ipa/rpi/controller/rpi/ccm.cpp            | 56 +++++--------------
 src/ipa/rpi/controller/rpi/ccm.h              | 35 +-----------
 src/{ipa/libipa => libcamera}/matrix.cpp      | 18 ++++--
 src/libcamera/meson.build                     |  1 +
 10 files changed, 48 insertions(+), 96 deletions(-)
 rename {src/ipa/libipa => include/libcamera/internal}/matrix.h (89%)
 rename src/{ipa/libipa => libcamera}/matrix.cpp (89%)