[v2,0/2] libipa: Initialize FrameContext with ActiveState
mbox series

Message ID 20241030164853.87586-1-jacopo.mondi@ideasonboard.com
Headers show
Series
  • libipa: Initialize FrameContext with ActiveState
Related show

Message

Jacopo Mondi Oct. 30, 2024, 4:48 p.m. UTC 
This version solves the same issue that v1 did, but takes in the suggestion
from Dan and Stefan to not initialize the FrameContext in the IPAFrameContext
but rather pass it through algorithms to let them initialize it.

This of course, only occours in case of Request underrun, where the
FrameContext is get() before it is alloc()-ated and passed through
algorithm's queueRequest() that initialize it with user provided Controls.

I think there's potential to rework the FCQueue to coalesce alloc() and get()
but that's for later.

Jacopo Mondi (2):
  libipa: FCQueue: Make sure FrameContext#0 is initialized
  ipa: rkisp1: Have algos initialize FrameContext

 src/ipa/libipa/fc_queue.cpp           |  6 ++++++
 src/ipa/libipa/fc_queue.h             | 26 +++++++++++++++++++++++++-
 src/ipa/rkisp1/algorithms/agc.cpp     |  8 ++++++++
 src/ipa/rkisp1/algorithms/agc.h       |  4 ++++
 src/ipa/rkisp1/algorithms/algorithm.h |  5 +++++
 src/ipa/rkisp1/rkisp1.cpp             |  9 +++++++++
 6 files changed, 57 insertions(+), 1 deletion(-)

--
2.47.0