[v6,0/2] Get black level from the camera helper
mbox series

Message ID 20241018141241.948698-1-mzamazal@redhat.com
Headers show
Series
  • Get black level from the camera helper
Related show

Message

Milan Zamazal Oct. 18, 2024, 2:12 p.m. UTC 
This patch takes the black level value for the given sensor from its
specification, if available.  The initial intention was to get the value
from the tuning file but in the meantime the value was added to
CameraSensorHelper so it’s taken from there.

Changes in v6:
- A forgotten testing statement removed.
- Using shift instead of division on the tuning value.

Changes in v5:
- Added a patch to take black level from the tuning file.

Changes in v4:
- Added braces around a single-line ‘if’ with a comment.

Changes in v3:
- A clarifying comment about the bit widths added.

Changes in v2:
- Rebased on the merged version of software ISP refactoring.
- The black level is represented as a pixel value rather than a 0..1
  floating value.

Milan Zamazal (2):
  libcamera: software_isp: Get black level from the camera helper
  libcamera: software_isp: Black level from tuning file

 src/ipa/simple/algorithms/blc.cpp | 19 ++++++++++++++++++-
 src/ipa/simple/algorithms/blc.h   |  1 +
 src/ipa/simple/ipa_context.h      |  4 ++++
 src/ipa/simple/soft_simple.cpp    | 11 +++++++++++
 4 files changed, 34 insertions(+), 1 deletion(-)